aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAndreas Gruenbacher <agruen@suse.de>2005-01-04 05:34:00 -0800
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-01-04 05:34:00 -0800
commit79a35a448eed5cc795f32625946b38a8a5f595ea (patch)
tree25e291fc5a0c6f1b67d3945d909c2bec41557506 /fs
parenteed6b962a0c41e5e89c7c767a961b30047b5464f (diff)
downloadhistory-79a35a448eed5cc795f32625946b38a8a5f595ea.tar.gz
[PATCH] Ext[23]: apply umask to symlinks with ACLs configured out
Keith Young <stripyd@stripydog.com> has reported that when ACLs are not compiled in, the default implementation of ext[23]_init_acl applies the umask to all new files, including symlinks, which is wrong. In this case the VFS already takes care of applying the umask when needed, so ext2 and ext3 need not bother about it. Remove the superfluous statements. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext2/acl.h1
-rw-r--r--fs/ext3/acl.h1
2 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext2/acl.h b/fs/ext2/acl.h
index f613bc33d0a2e4..dff187be531d7d 100644
--- a/fs/ext2/acl.h
+++ b/fs/ext2/acl.h
@@ -77,7 +77,6 @@ ext2_acl_chmod (struct inode *inode)
static inline int ext2_init_acl (struct inode *inode, struct inode *dir)
{
- inode->i_mode &= ~current->fs->umask;
return 0;
}
#endif
diff --git a/fs/ext3/acl.h b/fs/ext3/acl.h
index f83830d44d204d..f8975c74396f5b 100644
--- a/fs/ext3/acl.h
+++ b/fs/ext3/acl.h
@@ -79,7 +79,6 @@ ext3_acl_chmod(struct inode *inode)
static inline int
ext3_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
{
- inode->i_mode &= ~current->fs->umask;
return 0;
}
#endif /* CONFIG_EXT3_FS_POSIX_ACL */