aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorNeil Brown <neilb@cse.unsw.edu.au>2005-01-07 21:43:47 -0800
committerLinus Torvalds <torvalds@evo.osdl.org>2005-01-07 21:43:47 -0800
commit39a488d12d04e804506096c8d5333cc4a9b2db11 (patch)
tree9f8c2b09c9d64d233a86d3cbd201397faf4a96a6 /fs
parent97f7ccbd18d1e5aa145ad4eba0396a8d87ffd827 (diff)
downloadhistory-39a488d12d04e804506096c8d5333cc4a9b2db11.tar.gz
[PATCH] nfsd4_setclientid_confirm locking fix
Avoid unlock-without-lock problem on error path in nfsd4_setclientid_confirm Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/nfsd/nfs4state.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index ca5b440d715fd7..498f30290fa9b1 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -802,9 +802,8 @@ nfsd4_setclientid_confirm(struct svc_rqst *rqstp, struct nfsd4_setclientid_confi
clientid_t * clid = &setclientid_confirm->sc_clientid;
int status;
- status = nfserr_stale_clientid;
if (STALE_CLIENTID(clid))
- goto out;
+ return nfserr_stale_clientid;
/*
* XXX The Duplicate Request Cache (DRC) has been checked (??)
* We get here on a DRC miss.