aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorRussell King <rmk@flint.arm.linux.org.uk>2004-08-08 19:56:07 +0100
committerRussell King <rmk@flint.arm.linux.org.uk>2004-08-08 19:56:07 +0100
commit248b9d35c9ec722bb0f34f766e9cda0ab5dde69a (patch)
tree1468fee262372d88de95618f735f068cd367ca24 /drivers
parent0a54689e53360c84681786dfec67b875a7aa9f26 (diff)
downloadhistory-248b9d35c9ec722bb0f34f766e9cda0ab5dde69a.tar.gz
[ARM] Fix nwbutton sparse warnings
drivers/char/nwbutton.c:177:24: warning: incorrect type in argument 1 (different address spaces)/home/rmk/bk/linux-2.6-rmk/drivers/char/nwbutton.c:177:24: expected void [noderef] *to<asn:1> drivers/char/nwbutton.c:177:24: got char *buffer drivers/char/nwbutton.c:177:24: warning: incorrect type in initializer (different address spaces) drivers/char/nwbutton.c:177:24: expected void [noderef] *to<asn:1> drivers/char/nwbutton.c:177:24: got char *buffer drivers/char/nwbutton.c:189:11: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) drivers/char/nwbutton.c:189:11: expected int [usertype] ( *read )( ... ) drivers/char/nwbutton.c:189:11: got int ( static [addressable] [toplevel] *<noident> )( ... )
Diffstat (limited to 'drivers')
-rw-r--r--drivers/char/nwbutton.c2
-rw-r--r--drivers/char/nwbutton.h2
2 files changed, 1 insertions, 3 deletions
diff --git a/drivers/char/nwbutton.c b/drivers/char/nwbutton.c
index 513777e538f61a..4083b781adbffb 100644
--- a/drivers/char/nwbutton.c
+++ b/drivers/char/nwbutton.c
@@ -170,7 +170,7 @@ static irqreturn_t button_handler (int irq, void *dev_id, struct pt_regs *regs)
* device at any one time.
*/
-static int button_read (struct file *filp, char *buffer,
+static int button_read (struct file *filp, char __user *buffer,
size_t count, loff_t *ppos)
{
interruptible_sleep_on (&button_wait_queue);
diff --git a/drivers/char/nwbutton.h b/drivers/char/nwbutton.h
index 91176b5097abf9..ddb7b928dcbb5d 100644
--- a/drivers/char/nwbutton.h
+++ b/drivers/char/nwbutton.h
@@ -26,8 +26,6 @@ struct button_callback {
static void button_sequence_finished (unsigned long parameters);
static irqreturn_t button_handler (int irq, void *dev_id, struct pt_regs *regs);
-static int button_read (struct file *filp, char *buffer,
- size_t count, loff_t *ppos);
int button_init (void);
int button_add_callback (void (*callback) (void), int count);
int button_del_callback (void (*callback) (void));