diff options
author | Sam Ravnborg <sam@mars.ravnborg.org> | 2004-08-14 00:14:30 +0200 |
---|---|---|
committer | Sam Ravnborg <sam@mars.ravnborg.org> | 2004-08-14 00:14:30 +0200 |
commit | 29d28b2a027570e81d813f35d466c09ae54f4104 (patch) | |
tree | 17eb33f0c6e82c10ff9b41e0e436cf9d5b1dd42f /Makefile | |
parent | e78d165503d0dfefeed18f48f722f4bf4ad79014 (diff) | |
download | history-29d28b2a027570e81d813f35d466c09ae54f4104.tar.gz |
kbuild: __crc_* symbols in System.map
David S. Miller <davem@redhat.com> wrote:
Shouldn't we be grepping __crc_ symbols out of the System.map file?
For one thing, these can confuse readprofile. It's algorithm is
to start at _stext, then stop when it sees a line in the System.map
which is not text (mode is one of 'T' 't' 'W' or 'w')
It will exit early if there are some intermixed __crc_* things in
there (since they are are mode 'A').
For example, in my current sparc64 kernel I have this:
00000000004cef80 t do_split
00000000004cf2a0 t add_dirent_to_buf
00000000004cf5a7 A __crc_init_special_inode
00000000004cf640 t make_indexed_dir
00000000004cf900 t ext3_add_entry
So no symbols after add_dirent_to_buf will be shown in the profiling
output of readprofile.
Implementation ported to mksysmap by Sam.
Included two System.map related fixes:
- Print "SYSMAP System.map" during build
- Sort symbols in System.map
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Diffstat (limited to 'Makefile')
-rw-r--r-- | Makefile | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/Makefile b/Makefile index 56b4a072fa962c..7f058727f24408 100644 --- a/Makefile +++ b/Makefile @@ -608,12 +608,12 @@ endif define rule_vmlinux $(rule_vmlinux__); - $(Q)$(if $($(quiet)cmd_sysmap), \ - echo ' $($(quiet)cmd_sysmap) $@' &&) \ - $(cmd_sysmap) $@ System.map; \ - if [ $$? -ne 0 ]; then \ - rm -f $@; \ - /bin/false; \ + $(Q)$(if $($(quiet)cmd_sysmap), \ + echo ' $($(quiet)cmd_sysmap) System.map' &&) \ + $(cmd_sysmap) $@ System.map; \ + if [ $$? -ne 0 ]; then \ + rm -f $@; \ + /bin/false; \ fi; $(rule_verify_kallsyms) endef |