diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-11-24 12:16:11 +0000 |
---|---|---|
committer | Stefan Bader <stefan.bader@canonical.com> | 2014-12-15 15:00:58 +0100 |
commit | 3e43a359e77d0349c8339358816f2bc6779f6d24 (patch) | |
tree | e74105f056e3d664d9961fdde9fc4f3681b571ac | |
parent | 463b240fbe559e84d7960952c811d4eb8eee8982 (diff) | |
download | linux-2.6.32.y-drm33.z-3e43a359e77d0349c8339358816f2bc6779f6d24.tar.gz |
ttusb-dec: buffer overflow in ioctl
commit dc0ab1ddeb0c5f5eb3f37a72eadb394792b3c40d upstream
We need to add a limit check here so we don't overflow the buffer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
(backported from commit f2e323ec96077642d397bb1c355def536d489d16)
CVE-2014-8884
BugLink: http://bugs.launchpad.net/bugs/1395187
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Acked-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
-rw-r--r-- | drivers/media/dvb/ttusb-dec/ttusbdecfe.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/media/dvb/ttusb-dec/ttusbdecfe.c b/drivers/media/dvb/ttusb-dec/ttusbdecfe.c index 21260aad1e5468..852870b80df32a 100644 --- a/drivers/media/dvb/ttusb-dec/ttusbdecfe.c +++ b/drivers/media/dvb/ttusb-dec/ttusbdecfe.c @@ -154,6 +154,9 @@ static int ttusbdecfe_dvbs_diseqc_send_master_cmd(struct dvb_frontend* fe, struc 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; + if (cmd->msg_len > sizeof(b) - 4) + return -EINVAL; + memcpy(&b[4], cmd->msg, cmd->msg_len); state->config->send_command(fe, 0x72, |