diff options
| author | Steven Rostedt (Google) <rostedt@goodmis.org> | 2023-10-17 19:20:29 -0400 |
|---|---|---|
| committer | Steven Rostedt (Google) <rostedt@goodmis.org> | 2023-10-18 12:00:11 -0400 |
| commit | f0743ab4b8622d82d8a2585a46f782a58d59f5bf (patch) | |
| tree | b474c3d7029fcc9dbbe4919beb55617bc017a64c | |
| parent | 4f996b33a73e0f847a9e5ce6c46f2773dcac60f3 (diff) | |
| download | trace-cmd-f0743ab4b8622d82d8a2585a46f782a58d59f5bf.tar.gz | |
trace-cmd record: Cleanup - be consistent with return status variable
The variable that checks return status in daemonize_start() is "rc". To be
consistent with the rest of the code, change it to "ret".
Also check for less than zero instead of -1.
Link: https://lore.kernel.org/linux-trace-devel/20231017233503.2205514-3-rostedt@goodmis.org
Cc: Avidan Borisov <avidanborisov@gmail.com>
Cc: Ross Zwisler <zwisler@google.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
| -rw-r--r-- | tracecmd/trace-record.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index c943f486..022c27ff 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -1655,7 +1655,7 @@ static void daemonize_start(void) int devnull; int status; int pid; - int rc; + int ret; pid = fork(); if (pid == -1) @@ -1719,12 +1719,12 @@ static void daemonize_start(void) die("daemonize: sigaction failed"); do { - rc = waitpid(pid, &status, 0); - } while (!child_detached && ((rc == -1) && (errno == EINTR))); + ret = waitpid(pid, &status, 0); + } while (!child_detached && ((ret < 0) && (errno == EINTR))); if (child_detached) exit(0); - else if (rc == pid) + else if (ret == pid) exit(WIFEXITED(status)); else die("daemonize: waitpid failed"); |