diff options
| author | Martin Radev <martin.b.radev@gmail.com> | 2022-05-09 23:39:37 +0300 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2022-05-20 21:30:21 +0100 |
| commit | 06e1e6fe2e11a9b0d273e2d4e5b4f31e2f37a923 (patch) | |
| tree | 6df487b0dbfb56bd96a5453bc406e200af090a6c | |
| parent | 52d4ee7cb52071f6ca5cdd0c9e504c4f0fefcc35 (diff) | |
| download | kvmtool-06e1e6fe2e11a9b0d273e2d4e5b4f31e2f37a923.tar.gz | |
virtio: Use u32 instead of int in pci_data_in/out
The PCI access size type is changed from a signed type
to an unsigned type since the size is never expected to
be negative, and the type also matches the type in the
signature of virtio_pci__io_mmio_callback.
This change simplifies size checking in the next patch.
Reviewed-by: Alexandru Elisei <alexandru.elisei@arm.com>
Signed-off-by: Martin Radev <martin.b.radev@gmail.com>
Link: https://lore.kernel.org/r/20220509203940.754644-4-martin.b.radev@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
| -rw-r--r-- | virtio/pci.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/virtio/pci.c b/virtio/pci.c index 2777d1c8..bcb205a7 100644 --- a/virtio/pci.c +++ b/virtio/pci.c @@ -116,7 +116,7 @@ static inline bool virtio_pci__msix_enabled(struct virtio_pci *vpci) } static bool virtio_pci__specific_data_in(struct kvm *kvm, struct virtio_device *vdev, - void *data, int size, unsigned long offset) + void *data, u32 size, unsigned long offset) { u32 config_offset; struct virtio_pci *vpci = vdev->virtio; @@ -146,7 +146,7 @@ static bool virtio_pci__specific_data_in(struct kvm *kvm, struct virtio_device * } static bool virtio_pci__data_in(struct kvm_cpu *vcpu, struct virtio_device *vdev, - unsigned long offset, void *data, int size) + unsigned long offset, void *data, u32 size) { bool ret = true; struct virtio_pci *vpci; @@ -211,7 +211,7 @@ static void update_msix_map(struct virtio_pci *vpci, } static bool virtio_pci__specific_data_out(struct kvm *kvm, struct virtio_device *vdev, - void *data, int size, unsigned long offset) + void *data, u32 size, unsigned long offset) { struct virtio_pci *vpci = vdev->virtio; u32 config_offset, vec; @@ -285,7 +285,7 @@ static bool virtio_pci__specific_data_out(struct kvm *kvm, struct virtio_device } static bool virtio_pci__data_out(struct kvm_cpu *vcpu, struct virtio_device *vdev, - unsigned long offset, void *data, int size) + unsigned long offset, void *data, u32 size) { bool ret = true; struct virtio_pci *vpci; |