diff options
| author | Dave Jiang <dave.jiang@intel.com> | 2018-10-12 14:11:01 -0700 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2018-11-09 12:22:25 -0800 |
| commit | bddbf9de5dcd455addac2862e8bc3f41881d29f7 (patch) | |
| tree | 33b4bac08f60f16bb25f422ea067ec37191dd667 | |
| parent | 891c5e483b8c82c93a2661b3c8e929dd3658bd5a (diff) | |
| download | nvdimm-for-5.0/nvdimm-security.tar.gz | |
libnvdimm/security: Add warning output when request_key() failsfor-5.0/nvdimm-security
Provide useful error output when request_key() fails.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | drivers/nvdimm/security.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/nvdimm/security.c b/drivers/nvdimm/security.c index 3a905c58a935b1..5aacc590b4c071 100644 --- a/drivers/nvdimm/security.c +++ b/drivers/nvdimm/security.c @@ -73,11 +73,17 @@ static struct key *nvdimm_request_key(struct nvdimm *nvdimm) { struct key *key = NULL; char desc[NVDIMM_KEY_DESC_LEN + sizeof(NVDIMM_PREFIX)]; + struct device *dev = &nvdimm->dev; sprintf(desc, "%s%s", NVDIMM_PREFIX, nvdimm->dimm_id); key = request_key(&key_type_logon, desc, ""); - if (IS_ERR(key)) + if (IS_ERR(key)) { + if (PTR_ERR(key) == -ENOKEY) + dev_warn(dev, "request_key() found no key\n"); + else + dev_warn(dev, "request_key() upcall failed\n"); key = NULL; + } return key; } |