aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPerry Yuan <perry.yuan@amd.com>2023-01-10 23:10:29 +0800
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2023-01-10 20:31:08 +0100
commit4f3085f87b51a551a0647f218d4f324796ecb703 (patch)
tree1eaf2e8a6352ac91c657b3f17c2c99fcc87df218
parent7e834ff13c4fcdf2bbd0eaf740781445d9c45d2e (diff)
downloadlinux-4f3085f87b51a551a0647f218d4f324796ecb703.tar.gz
cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering
In the amd_pstate_adjust_perf(), there is one cpufreq_cpu_get() call to increase increments the kobject reference count of policy and make it as busy. Therefore, a corresponding call to cpufreq_cpu_put() is needed to decrement the kobject reference count back, it will resolve the kernel hang issue when unregistering the amd-pstate driver and register the `amd_pstate_epp` driver instance. Fixes: 1d215f0319 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State") Acked-by: Huang Rui <ray.huang@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Tested-by: Wyes Karny <wyes.karny@amd.com> Signed-off-by: Perry Yuan <perry.yuan@amd.com> Cc: 5.17+ <stable@vger.kernel.org> # 5.17+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/cpufreq/amd-pstate.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 204e39006dda8f..c17bd845f5fcb8 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
max_perf = min_perf;
amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true);
+ cpufreq_cpu_put(policy);
}
static int amd_get_min_freq(struct amd_cpudata *cpudata)