aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2014-12-19 11:09:13 +0800
committerDavid S. Miller <davem@davemloft.net>2014-12-23 23:12:11 -0500
commitaf6dabc9c70ae3f307685b1f32f52d60b1bf0527 (patch)
tree8cc35a3385ef42c3a29d395d65abd3e68bf052ba
parent2dc49d1680b534877fd20cce52557ea542bb06b6 (diff)
downloadlinux-af6dabc9c70ae3f307685b1f32f52d60b1bf0527.tar.gz
net: drop the packet when fails to do software segmentation or header check
Commit cecda693a969816bac5e470e1d9c9c0ef5567bca ("net: keep original skb which only needs header checking during software GSO") keeps the original skb for packets that only needs header check, but it doesn't drop the packet if software segmentation or header check were failed. Fixes cecda693a9 ("net: keep original skb which only needs header checking during software GSO") Cc: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index f411c28d0a6680..a989f850241217 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2673,7 +2673,7 @@ static struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device
segs = skb_gso_segment(skb, features);
if (IS_ERR(segs)) {
- segs = NULL;
+ goto out_kfree_skb;
} else if (segs) {
consume_skb(skb);
skb = segs;