diff options
| author | Xin Long <lucien.xin@gmail.com> | 2020-12-07 15:55:40 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-12-07 00:32:11 -0800 |
| commit | 10c678bd0a035ac2c64a9b26b222f20556227a53 (patch) | |
| tree | 455c2e9f949652022a931100901157104394e64e | |
| parent | 61f54de2e9194f01874d5eda12037b0978e77519 (diff) | |
| download | linux-fullhistory-10c678bd0a035ac2c64a9b26b222f20556227a53.tar.gz | |
udp: fix the proto value passed to ip_protocol_deliver_rcu for the segments
Guillaume noticed that: for segments udp_queue_rcv_one_skb() returns the
proto, and it should pass "ret" unmodified to ip_protocol_deliver_rcu().
Otherwize, with a negtive value passed, it will underflow inet_protos.
This can be reproduced with IPIP FOU:
# ip fou add port 5555 ipproto 4
# ethtool -K eth1 rx-gro-list on
Fixes: cf329aa42b66 ("udp: cope with UDP GRO packet misdirection")
Reported-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/udp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 09f0a23d1a0174..9eeebd4a00542c 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -2173,7 +2173,7 @@ static int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) __skb_pull(skb, skb_transport_offset(skb)); ret = udp_queue_rcv_one_skb(sk, skb); if (ret > 0) - ip_protocol_deliver_rcu(dev_net(skb->dev), skb, -ret); + ip_protocol_deliver_rcu(dev_net(skb->dev), skb, ret); } return 0; } |