diff options
| author | Greg Kurz <groug@kaod.org> | 2019-11-06 13:46:40 +0100 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2019-11-12 10:34:23 +0100 |
| commit | 88ed5db16c9b8ee2a6ec6d285f542b0a68a3c6e1 (patch) | |
| tree | 4403bbe5270e08bbb4831c9ba6525a873f54e333 | |
| parent | d55e937d3eb07ed98a0554517e5098b51e37a62f (diff) | |
| download | qemu-88ed5db16c9b8ee2a6ec6d285f542b0a68a3c6e1.tar.gz | |
numa: Add missing \n to error message
If memory allocation fails when using -mem-path, QEMU is supposed to print
out a message to indicate that fallback to anonymous RAM is deprecated. This
is done with error_printf() which does output buffering. As a consequence,
the message is only printed at the next flush, eg. when quiting QEMU, and
it also lacks a trailing newline:
qemu-system-ppc64: unable to map backing store for guest RAM: Cannot allocate memory
qemu-system-ppc64: warning: falling back to regular RAM allocation
QEMU 4.1.50 monitor - type 'help' for more information
(qemu) q
This is deprecated. Make sure that -mem-path specified path has sufficient resources to allocate -m specified RAM amountgreg@boss02:~/Work/qemu/qemu-spapr$
Add the missing \n to fix both issues.
Fixes: cb79224b7e4b "deprecate -mem-path fallback to anonymous RAM"
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <157304440026.351774.14607704217028190097.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/core/numa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/core/numa.c b/hw/core/numa.c index 038c96d4abc..e3332a984f7 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -503,7 +503,7 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, warn_report("falling back to regular RAM allocation"); error_printf("This is deprecated. Make sure that -mem-path " " specified path has sufficient resources to allocate" - " -m specified RAM amount"); + " -m specified RAM amount\n"); /* Legacy behavior: if allocation failed, fall back to * regular RAM allocation. */ |