diff options
author | Peilin Ye <peilin.ye@bytedance.com> | 2022-05-24 19:52:09 -0700 |
---|---|---|
committer | David Ahern <dsahern@kernel.org> | 2022-05-30 09:53:55 -0600 |
commit | b38831bc23c40b3fa8ad518478173fa007d0cbbf (patch) | |
tree | c072ac180d5cd12507f1ee05a62f9f0760903272 | |
parent | 2d866c6d93dbf4fe8169dda4a3a8f4a67fa0a5b9 (diff) | |
download | iproute2-b38831bc23c40b3fa8ad518478173fa007d0cbbf.tar.gz |
ss: Remove unnecessary stack variable 'p' in user_ent_hash_build()
Commit 116ac9270b6d ("ss: Add support for retrieving SELinux contexts")
added an unnecessary stack variable, 'char *p', in
user_ent_hash_build(). Delete it for readability.
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
-rw-r--r-- | misc/ss.c | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -618,7 +618,6 @@ static void user_ent_hash_build(void) while ((d = readdir(dir)) != NULL) { struct dirent *d1; char process[16]; - char *p; int pid, pos; DIR *dir1; @@ -636,7 +635,6 @@ static void user_ent_hash_build(void) } process[0] = '\0'; - p = process; while ((d1 = readdir(dir1)) != NULL) { const char *pattern = "socket:["; @@ -667,18 +665,18 @@ static void user_ent_hash_build(void) if (getfilecon(tmp, &sock_context) <= 0) sock_context = strdup(no_ctx); - if (*p == '\0') { + if (process[0] == '\0') { FILE *fp; snprintf(tmp, sizeof(tmp), "%s/%d/stat", root, pid); if ((fp = fopen(tmp, "r")) != NULL) { - if (fscanf(fp, "%*d (%[^)])", p) < 1) + if (fscanf(fp, "%*d (%[^)])", process) < 1) ; /* ignore */ fclose(fp); } } - user_ent_add(ino, p, pid, fd, + user_ent_add(ino, process, pid, fd, pid_context, sock_context); freecon(sock_context); } |