diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-12-29 13:09:00 +0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2023-01-02 11:45:43 -0300 |
| commit | 0a6564ebd953c4590663c9a3c99a3ea9920ade6f (patch) | |
| tree | 65b93c47c9f493a55cb86de8ab45ffe93388f403 | |
| parent | 88603b6dc419445847923fcb7fe5080067a30f98 (diff) | |
| download | pci-0a6564ebd953c4590663c9a3c99a3ea9920ade6f.tar.gz | |
perf tools: Fix resources leak in perf_data__open_dir()
In perf_data__open_dir(), opendir() opens the directory stream. Add
missing closedir() to release it after use.
Fixes: eb6176709b235b96 ("perf data: Add perf_data__open_dir_data function")
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221229090903.1402395-1-linmq006@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/util/data.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c index a7f68c309545de..fc16299c915f9b 100644 --- a/tools/perf/util/data.c +++ b/tools/perf/util/data.c @@ -132,6 +132,7 @@ int perf_data__open_dir(struct perf_data *data) file->size = st.st_size; } + closedir(dir); if (!files) return -EINVAL; @@ -140,6 +141,7 @@ int perf_data__open_dir(struct perf_data *data) return 0; out_err: + closedir(dir); close_dir(files, nr); return ret; } |