diff options
author | Lucas De Marchi <lucas.demarchi@profusion.mobi> | 2012-05-23 20:27:23 -0300 |
---|---|---|
committer | Lucas De Marchi <lucas.demarchi@profusion.mobi> | 2012-05-23 20:27:23 -0300 |
commit | a70c1e774e595039c321c1c2e99d43e4c9bd0fa8 (patch) | |
tree | 08a86764a7fde764fc997a91ec510cd07beaad88 | |
parent | 5bbec8cdcb89df3b786437f901cfea92e7164b7a (diff) | |
download | kmod-a70c1e774e595039c321c1c2e99d43e4c9bd0fa8.tar.gz |
Don't use __ for attribute defines
System headers use __, don't mess with them.
-rw-r--r-- | libkmod/libkmod-private.h | 50 | ||||
-rw-r--r-- | libkmod/libkmod-util.h | 12 | ||||
-rw-r--r-- | libkmod/macro.h | 8 |
3 files changed, 34 insertions, 36 deletions
diff --git a/libkmod/libkmod-private.h b/libkmod/libkmod-private.h index ebda945..f21e0a9 100644 --- a/libkmod/libkmod-private.h +++ b/libkmod/libkmod-private.h @@ -9,7 +9,7 @@ #include "macro.h" #include "libkmod.h" -static __always_inline __printf_format(2, 3) void +static _always_inline_ _printf_format_(2, 3) void kmod_log_null(struct kmod_ctx *ctx, const char *format, ...) {} #define kmod_log_cond(ctx, prio, arg...) \ @@ -49,16 +49,16 @@ struct kmod_list { void *data; }; -struct kmod_list *kmod_list_append(struct kmod_list *list, const void *data) __must_check __attribute__((nonnull(2))); -struct kmod_list *kmod_list_prepend(struct kmod_list *list, const void *data) __must_check __attribute__((nonnull(2))); -struct kmod_list *kmod_list_remove(struct kmod_list *list) __must_check; +struct kmod_list *kmod_list_append(struct kmod_list *list, const void *data) _must_check_ __attribute__((nonnull(2))); +struct kmod_list *kmod_list_prepend(struct kmod_list *list, const void *data) _must_check_ __attribute__((nonnull(2))); +struct kmod_list *kmod_list_remove(struct kmod_list *list) _must_check_; struct kmod_list *kmod_list_remove_data(struct kmod_list *list, - const void *data) __must_check __attribute__((nonnull(2))); + const void *data) _must_check_ __attribute__((nonnull(2))); struct kmod_list *kmod_list_remove_n_latest(struct kmod_list *list, - unsigned int n) __must_check; + unsigned int n) _must_check_; struct kmod_list *kmod_list_insert_after(struct kmod_list *list, const void *data) __attribute__((nonnull(2))); struct kmod_list *kmod_list_insert_before(struct kmod_list *list, const void *data) __attribute__((nonnull(2))); -struct kmod_list *kmod_list_append_list(struct kmod_list *list1, struct kmod_list *list2) __must_check; +struct kmod_list *kmod_list_append_list(struct kmod_list *list1, struct kmod_list *list2) _must_check_; #undef kmod_list_foreach #define kmod_list_foreach(list_entry, first_entry) \ @@ -91,12 +91,12 @@ struct kmod_module *kmod_pool_get_module(struct kmod_ctx *ctx, const char *key) void kmod_pool_add_module(struct kmod_ctx *ctx, struct kmod_module *mod, const char *key) __attribute__((nonnull(1,2, 3))); void kmod_pool_del_module(struct kmod_ctx *ctx, struct kmod_module *mod, const char *key) __attribute__((nonnull(1,2, 3))); -const struct kmod_list *kmod_get_blacklists(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); -const struct kmod_list *kmod_get_options(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); -const struct kmod_list *kmod_get_install_commands(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); -const struct kmod_list *kmod_get_remove_commands(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); -const struct kmod_list *kmod_get_softdeps(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); -const struct kmod_list *kmod_get_aliases(const struct kmod_ctx *ctx) __must_check __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_blacklists(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_options(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_install_commands(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_remove_commands(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_softdeps(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); +const struct kmod_list *kmod_get_aliases(const struct kmod_ctx *ctx) _must_check_ __attribute__((nonnull(1))); /* libkmod-config.c */ @@ -145,9 +145,9 @@ void kmod_module_set_builtin(struct kmod_module *mod, bool builtin) __attribute_ #include "libkmod-hash.h" /* libkmod-file.c */ -struct kmod_file *kmod_file_open(const struct kmod_ctx *ctx, const char *filename) __must_check __attribute__((nonnull(1,2))); -void *kmod_file_get_contents(const struct kmod_file *file) __must_check __attribute__((nonnull(1))); -off_t kmod_file_get_size(const struct kmod_file *file) __must_check __attribute__((nonnull(1))); +struct kmod_file *kmod_file_open(const struct kmod_ctx *ctx, const char *filename) _must_check_ __attribute__((nonnull(1,2))); +void *kmod_file_get_contents(const struct kmod_file *file) _must_check_ __attribute__((nonnull(1))); +off_t kmod_file_get_size(const struct kmod_file *file) _must_check_ __attribute__((nonnull(1))); void kmod_file_unref(struct kmod_file *file) __attribute__((nonnull(1))); /* libkmod-elf.c */ @@ -158,21 +158,21 @@ struct kmod_modversion { char *symbol; }; -struct kmod_elf *kmod_elf_new(const void *memory, off_t size) __must_check __attribute__((nonnull(1))); +struct kmod_elf *kmod_elf_new(const void *memory, off_t size) _must_check_ __attribute__((nonnull(1))); void kmod_elf_unref(struct kmod_elf *elf) __attribute__((nonnull(1))); -const void *kmod_elf_get_memory(const struct kmod_elf *elf) __must_check __attribute__((nonnull(1))); -int kmod_elf_get_strings(const struct kmod_elf *elf, const char *section, char ***array) __must_check __attribute__((nonnull(1,2,3))); -int kmod_elf_get_modversions(const struct kmod_elf *elf, struct kmod_modversion **array) __must_check __attribute__((nonnull(1,2))); -int kmod_elf_get_symbols(const struct kmod_elf *elf, struct kmod_modversion **array) __must_check __attribute__((nonnull(1,2))); -int kmod_elf_get_dependency_symbols(const struct kmod_elf *elf, struct kmod_modversion **array) __must_check __attribute__((nonnull(1,2))); -int kmod_elf_strip_section(struct kmod_elf *elf, const char *section) __must_check __attribute__((nonnull(1,2))); -int kmod_elf_strip_vermagic(struct kmod_elf *elf) __must_check __attribute__((nonnull(1))); +const void *kmod_elf_get_memory(const struct kmod_elf *elf) _must_check_ __attribute__((nonnull(1))); +int kmod_elf_get_strings(const struct kmod_elf *elf, const char *section, char ***array) _must_check_ __attribute__((nonnull(1,2,3))); +int kmod_elf_get_modversions(const struct kmod_elf *elf, struct kmod_modversion **array) _must_check_ __attribute__((nonnull(1,2))); +int kmod_elf_get_symbols(const struct kmod_elf *elf, struct kmod_modversion **array) _must_check_ __attribute__((nonnull(1,2))); +int kmod_elf_get_dependency_symbols(const struct kmod_elf *elf, struct kmod_modversion **array) _must_check_ __attribute__((nonnull(1,2))); +int kmod_elf_strip_section(struct kmod_elf *elf, const char *section) _must_check_ __attribute__((nonnull(1,2))); +int kmod_elf_strip_vermagic(struct kmod_elf *elf) _must_check_ __attribute__((nonnull(1))); /* * Debug mock lib need to find section ".gnu.linkonce.this_module" in order to * get modname */ -int kmod_elf_get_section(const struct kmod_elf *elf, const char *section, const void **buf, uint64_t *buf_size) __must_check __attribute__((nonnull(1,2,3,4))); +int kmod_elf_get_section(const struct kmod_elf *elf, const char *section, const void **buf, uint64_t *buf_size) _must_check_ __attribute__((nonnull(1,2,3,4))); /* util functions */ #include "libkmod-util.h" diff --git a/libkmod/libkmod-util.h b/libkmod/libkmod-util.h index dae613a..343f1e2 100644 --- a/libkmod/libkmod-util.h +++ b/libkmod/libkmod-util.h @@ -13,14 +13,14 @@ char *getline_wrapped(FILE *fp, unsigned int *linenum) __attribute__((nonnull(1) #define strstartswith(a, b) (strncmp(a, b, strlen(b)) == 0) void *memdup(const void *p, size_t n) __attribute__((nonnull(1))); -ssize_t read_str_safe(int fd, char *buf, size_t buflen) __must_check __attribute__((nonnull(2))); +ssize_t read_str_safe(int fd, char *buf, size_t buflen) _must_check_ __attribute__((nonnull(2))); ssize_t write_str_safe(int fd, const char *buf, size_t buflen) __attribute__((nonnull(2))); -int read_str_long(int fd, long *value, int base) __must_check __attribute__((nonnull(2))); -int read_str_ulong(int fd, unsigned long *value, int base) __must_check __attribute__((nonnull(2))); +int read_str_long(int fd, long *value, int base) _must_check_ __attribute__((nonnull(2))); +int read_str_ulong(int fd, unsigned long *value, int base) _must_check_ __attribute__((nonnull(2))); char *strchr_replace(char *s, int c, char r); -bool path_is_absolute(const char *p) __must_check __attribute__((nonnull(1))); -char *path_make_absolute_cwd(const char *p) __must_check __attribute__((nonnull(1))); -int alias_normalize(const char *alias, char buf[PATH_MAX], size_t *len) __must_check __attribute__((nonnull(1,2))); +bool path_is_absolute(const char *p) _must_check_ __attribute__((nonnull(1))); +char *path_make_absolute_cwd(const char *p) _must_check_ __attribute__((nonnull(1))); +int alias_normalize(const char *alias, char buf[PATH_MAX], size_t *len) _must_check_ __attribute__((nonnull(1,2))); char *modname_normalize(const char *modname, char buf[PATH_MAX], size_t *len) __attribute__((nonnull(1, 2))); char *path_to_modname(const char *path, char buf[PATH_MAX], size_t *len) __attribute__((nonnull(2))); unsigned long long stat_mstamp(const struct stat *st); diff --git a/libkmod/macro.h b/libkmod/macro.h index 06300df..8716315 100644 --- a/libkmod/macro.h +++ b/libkmod/macro.h @@ -78,10 +78,8 @@ /* Attributes */ -#define __must_check __attribute__((warn_unused_result)) -#define __printf_format(a,b) __attribute__((format (printf, a, b))) -#if !defined(__always_inline) -#define __always_inline __inline__ __attribute__((always_inline)) -#endif +#define _must_check_ __attribute__((warn_unused_result)) +#define _printf_format_(a,b) __attribute__((format (printf, a, b))) +#define _always_inline_ __inline__ __attribute__((always_inline)) #endif |