diff options
| author | Florian Westphal <fw@strlen.de> | 2023-05-11 14:15:15 +0200 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2023-05-17 14:16:02 +0200 |
| commit | e3c361b8acd636f5fe80c02849ca175201edf10c (patch) | |
| tree | 2414d2eac0572f7efb5ba3a44d5d42387bf63e0a | |
| parent | 224a876e37543eee111bf9b6aa4935080e619335 (diff) | |
| download | linux-e3c361b8acd636f5fe80c02849ca175201edf10c.tar.gz | |
netfilter: nf_tables: fix nft_trans type confusion
nft_trans_FOO objects all share a common nft_trans base structure, but
trailing fields depend on the real object size. Access is only safe after
trans->msg_type check.
Check for rule type first. Found by code inspection.
Fixes: 1a94e38d254b ("netfilter: nf_tables: add NFTA_RULE_ID attribute")
Signed-off-by: Florian Westphal <fw@strlen.de>
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 59fb8320ab4d7..dc5675962de4f 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -3865,12 +3865,10 @@ static struct nft_rule *nft_rule_lookup_byid(const struct net *net, struct nft_trans *trans; list_for_each_entry(trans, &nft_net->commit_list, list) { - struct nft_rule *rule = nft_trans_rule(trans); - if (trans->msg_type == NFT_MSG_NEWRULE && trans->ctx.chain == chain && id == nft_trans_rule_id(trans)) - return rule; + return nft_trans_rule(trans); } return ERR_PTR(-ENOENT); } |