diff options
| author | Taeung Song <treeze.taeung@gmail.com> | 2017-04-26 23:55:40 +0900 |
|---|---|---|
| committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2017-04-26 15:09:54 -0400 |
| commit | 1c47f105119646c5c95c57c176239cc1d9893d5d (patch) | |
| tree | a9edcb197aadc211b801bf3010687ffc99750b97 | |
| parent | 49cb7d0124618bd215cdf0b421b9a816a8d2648e (diff) | |
| download | trace-cmd-1c47f105119646c5c95c57c176239cc1d9893d5d.tar.gz | |
parse-events: Fix missing break in FALSE case of pevent_filter_clear_trivial()
Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if
the trivial type is FALSE, it will also run into the TRUE case, and always
be skipped as the TRUE statement will continue the loop on the inverse
condition of the FALSE statement.
Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.taeung@gmail.com
Reported-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
| -rw-r--r-- | parse-filter.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/parse-filter.c b/parse-filter.c index 7c214ceb..c2fd26fd 100644 --- a/parse-filter.c +++ b/parse-filter.c @@ -1634,6 +1634,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, case FILTER_TRIVIAL_FALSE: if (filter_type->filter->boolean.value) continue; + break; case FILTER_TRIVIAL_TRUE: if (!filter_type->filter->boolean.value) continue; |