aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChao Yu <chao@kernel.org>2023-07-19 15:01:22 +0800
committerJaegeuk Kim <jaegeuk@kernel.org>2023-07-21 10:26:44 -0700
commitb995da33671b87804342095af9746963ce304c1a (patch)
tree31d1a00277ee76354fa3aa71e9f43db944da1832
parentbb8af9c06a1e7fcdbe60b61575b90f5b317e6c62 (diff)
downloadf2fs-tools-b995da33671b87804342095af9746963ce304c1a.tar.gz
dump.f2fs: remove redundant check condition in dump_node()
In dump_node(), f2fs_is_valid_blkaddr() has checked ni.blk_addr's validity and dump_node() will bail up if ni.blk_addr is invalid, so let's remove redundant check condition and print below: if (ni.blk_addr == 0x0) MSG(force, "Invalid nat entry\n\n"); Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r--fsck/dump.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fsck/dump.c b/fsck/dump.c
index dd1f0ab..6deaa7e 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -596,9 +596,7 @@ int dump_node(struct f2fs_sb_info *sbi, nid_t nid, int force)
dev_read_block(node_blk, ni.blk_addr);
- if (ni.blk_addr == 0x0)
- MSG(force, "Invalid nat entry\n\n");
- else if (!is_sit_bitmap_set(sbi, ni.blk_addr))
+ if (!is_sit_bitmap_set(sbi, ni.blk_addr))
MSG(force, "Invalid sit bitmap, %u\n\n", ni.blk_addr);
DBG(1, "node_blk.footer.ino [0x%x]\n", le32_to_cpu(node_blk->footer.ino));