diff options
| author | Zong-Zhe Yang <kevin_yang@realtek.com> | 2023-01-03 22:10:54 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-01-16 15:35:21 +0200 |
| commit | 4a0e218cc9c42d1903ade8b5a371dcf48cf918c5 (patch) | |
| tree | 4cda1b4f183e61f4e45785010e93329a92da519f | |
| parent | 3f625adc61a0f015c2ce982bc49a84e163094a0c (diff) | |
| download | iwlwifi-next-4a0e218cc9c42d1903ade8b5a371dcf48cf918c5.tar.gz | |
wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie()
Do `kfree_skb(new)` before `goto out` to prevent potential leak.
Fixes: 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan")
Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230103141054.17372-1-pkshih@realtek.com
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/fw.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c index 19a49ef243fa4d..98cfadda8f45e8 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -2686,8 +2686,10 @@ static int rtw89_append_probe_req_ie(struct rtw89_dev *rtwdev, list_add_tail(&info->list, &scan_info->pkt_list[band]); ret = rtw89_fw_h2c_add_pkt_offload(rtwdev, &info->id, new); - if (ret) + if (ret) { + kfree_skb(new); goto out; + } kfree_skb(new); } |