diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2020-08-17 14:19:30 +0200 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2020-08-25 09:42:51 +0200 |
| commit | 914a7b3563b8fb92f976619bbd0fa3a4a708baae (patch) | |
| tree | c4b4a5903a112f89dd496f7326a260c46ea3a365 | |
| parent | e4682b8a688bc3352e663545ad51997c3d84877b (diff) | |
| download | linux-visconti-914a7b3563b8fb92f976619bbd0fa3a4a708baae.tar.gz | |
i2c: rcar: in slave mode, clear NACK earlier
Currently, a NACK in slave mode is set/cleared when SCL is held low by
the IP core right before the bit is about to be pushed out. This is too
late for clearing and then a NACK from the previous byte is still used
for the current one. Now, let's clear the NACK right after we detected
the STOP condition following the NACK.
Fixes: de20d1857dd6 ("i2c: rcar: add slave support")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
| -rw-r--r-- | drivers/i2c/busses/i2c-rcar.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 9e883474db8ceb..c7c543483b08ca 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -590,6 +590,7 @@ static bool rcar_i2c_slave_irq(struct rcar_i2c_priv *priv) /* master sent stop */ if (ssr_filtered & SSR) { i2c_slave_event(priv->slave, I2C_SLAVE_STOP, &value); + rcar_i2c_write(priv, ICSCR, SIE | SDBS); /* clear our NACK */ rcar_i2c_write(priv, ICSIER, SAR); rcar_i2c_write(priv, ICSSR, ~SSR & 0xff); } |