diff options
| author | Nam Dang <nam.dang.uw@rvc.renesas.com> | 2019-03-12 16:57:07 +0700 |
|---|---|---|
| committer | Ryo Kataoka <ryo.kataoka.wt@renesas.com> | 2019-03-22 20:50:36 +0900 |
| commit | af9c7b7ce7b0710af19f4b8c10334892fd0674d6 (patch) | |
| tree | c7efcb215e410f0f56d9c0742b7a69ff97af0c7d | |
| parent | 9fd5e585515b809fac299f6d4b42844d34f8d58c (diff) | |
| download | renesas-bsp-af9c7b7ce7b0710af19f4b8c10334892fd0674d6.tar.gz | |
mfd: bd9571mwv: fix section mismatch
1. Fix issue build warning "section mismatch"
2. Add some comments to make more clearly
Signed-off-by: Nam Dang <nam.dang.uw@rvc.renesas.com>
| -rw-r--r-- | drivers/mfd/bd9571mwv.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c index a3cd1dceae3580..8774d500e62096 100644 --- a/drivers/mfd/bd9571mwv.c +++ b/drivers/mfd/bd9571mwv.c @@ -195,14 +195,14 @@ static struct regmap_irq_chip bd9574mwf_irq_chip = { .num_irqs = ARRAY_SIZE(bd9574mwf_irqs), }; -static const struct bd957x_data bd9571mwv_data __initconst = { +static const struct bd957x_data bd9571mwv_data = { .product_code_val = BD9571MWV_PRODUCT_CODE_VAL, .part_number = BD9571MWV_PART_NUMBER, .regmap_config = &bd9571mwv_regmap_config, .irq_chip = &bd9571mwv_irq_chip, }; -static const struct bd957x_data bd9574mwf_data __initconst = { +static const struct bd957x_data bd9574mwf_data = { .product_code_val = BD9574MWF_PRODUCT_CODE_VAL, .part_number = BD9574MWF_PART_NUMBER, .regmap_config = &bd9574mwf_regmap_config, @@ -246,7 +246,7 @@ static int bd9571mwv_identify(struct bd9571mwv *bd) ret); return ret; } - + /* Confirm the product code */ if (value != bd_data->product_code_val) { dev_err(dev, "Invalid product code ID %02x (expected %02x)\n", value, bd_data->product_code_val); @@ -280,6 +280,7 @@ static int bd9571mwv_probe(struct i2c_client *client, bd->dev = &client->dev; bd->irq = client->irq; + /* Read the PMIC product code */ ret = i2c_smbus_read_byte_data(client, BD9571MWV_PRODUCT_CODE); if (ret < 0) { dev_err(&client->dev, "failed reading at 0x%02x\n", @@ -289,9 +290,10 @@ static int bd9571mwv_probe(struct i2c_client *client, product_code = (unsigned int)ret; + /* Init data for PMIC device base on product code */ if (product_code == BD9571MWV_PRODUCT_CODE_VAL) bd_data = &bd9571mwv_data; - else /* BD9574MWF */ + else bd_data = &bd9574mwf_data; bd->regmap = devm_regmap_init_i2c(client, bd_data->regmap_config); |