diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-01-03 11:22:00 -0800 |
|---|---|---|
| committer | Eryu Guan <eguan@redhat.com> | 2018-01-09 18:33:24 +0800 |
| commit | dc325ce8cafd6a319f3e6d24a5b76c7e156af1ba (patch) | |
| tree | 7756559e640cb8f611b5c1248861b60e70693a5e | |
| parent | 95c924c65113d2b706436d8cd09cd391eddb795a (diff) | |
| download | xfstests-dev-dc325ce8cafd6a319f3e6d24a5b76c7e156af1ba.tar.gz | |
xfs: find libxfs api violations
New test to run tools/find-api-violations.sh in xfsprogs.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
| -rwxr-xr-x | tests/xfs/437 | 56 | ||||
| -rw-r--r-- | tests/xfs/437.out | 2 | ||||
| -rw-r--r-- | tests/xfs/group | 1 |
3 files changed, 59 insertions, 0 deletions
diff --git a/tests/xfs/437 b/tests/xfs/437 new file mode 100755 index 0000000000..c249b96cd6 --- /dev/null +++ b/tests/xfs/437 @@ -0,0 +1,56 @@ +#! /bin/bash +# FS QA Test No. 437 +# +# find-api-violations test +# +# The purpose of this test is ensure that the xfsprogs programs use the +# libxfs_ symbols (in libxfs-api-defs.h) instead of raw xfs_ functions. +# This is for the maintainers; it's not a functionality test. +# +#----------------------------------------------------------------------- +# Copyright (c) 2018 Oracle, Inc. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +[ -z "$WORKAREA" ] && \ + _notrun "Can't run find-api-violations.sh without WORKAREA set" +[ -f "$WORKAREA/tools/find-api-violations.sh" ] || \ + _notrun "Can't find find-api-violations.sh tool under \"$WORKAREA\"" + +echo "Silence is golden." + +# Look for API usage problems. Old versions of the script have an improperly +# specified grep pattern that is mistaken for a (broken) range specifier in +# LC_ALL=C, so use English instead. +(cd "$WORKAREA" ; LC_ALL="en_US.UTF-8" bash ./tools/find-api-violations.sh ) | tee -a $seqres.full + +# success, all done +status=0 +exit diff --git a/tests/xfs/437.out b/tests/xfs/437.out new file mode 100644 index 0000000000..78e57ee889 --- /dev/null +++ b/tests/xfs/437.out @@ -0,0 +1,2 @@ +QA output created by 437 +Silence is golden. diff --git a/tests/xfs/group b/tests/xfs/group index d23006041e..7de3ef0b51 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -434,3 +434,4 @@ 434 auto quick clone fsr 435 auto quick clone 436 auto quick clone fsr +437 auto quick other |