diff options
| author | Andreea-Cristina Bernat <bernat.ada@gmail.com> | 2014-08-22 17:50:43 +0300 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2014-09-05 08:11:57 +0200 |
| commit | 35b123e2f701b28977db2cde7dbbdb3fad28cad1 (patch) | |
| tree | 27019a13ac925dfc619ebbb425fd285ccdbcac5b | |
| parent | 163122b7fcfa28c0e4a838fcc8043c616746802e (diff) | |
| download | tip-35b123e2f701b28977db2cde7dbbdb3fad28cad1.tar.gz | |
sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: paulmck@linux.vnet.ibm.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140822145043.GA580@ada
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | kernel/sched/fair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d3427a8f254bff..02fc949eb34828 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1780,7 +1780,7 @@ void task_numa_free(struct task_struct *p) list_del(&p->numa_entry); grp->nr_tasks--; spin_unlock_irqrestore(&grp->lock, flags); - rcu_assign_pointer(p->numa_group, NULL); + RCU_INIT_POINTER(p->numa_group, NULL); put_numa_group(grp); } |