diff options
| author | Lucy Mielke <lucymielke@icloud.com> | 2023-10-09 19:09:46 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2023-10-12 09:53:40 -1000 |
| commit | 5d9c7a1e3e8e18db8e10c546de648cda2a57be52 (patch) | |
| tree | b7ed8b5138f0c06ebf09c7e8f68925b6de9c2d04 | |
| parent | ca10d851b9ad0338c19e8e3089e24d565ebfffd7 (diff) | |
| download | linux-5d9c7a1e3e8e18db8e10c546de648cda2a57be52.tar.gz | |
workqueue: fix -Wformat-truncation in create_worker
Compiling with W=1 emitted the following warning
(Compiler: gcc (x86-64, ver. 13.2.1, .config: result of make allyesconfig,
"Treat warnings as errors" turned off):
kernel/workqueue.c:2188:54: warning: ‘%d’ directive output may be
truncated writing between 1 and 10 bytes into a region of size
between 5 and 14 [-Wformat-truncation=]
kernel/workqueue.c:2188:50: note: directive argument in the range
[0, 2147483647]
kernel/workqueue.c:2188:17: note: ‘snprintf’ output between 4 and 23 bytes
into a destination of size 16
setting "id_buf" to size 23 will silence the warning, since GCC
determines snprintf's output to be max. 23 bytes in line 2188.
Please let me know if there are any mistakes in my patch!
Signed-off-by: Lucy Mielke <lucymielke@icloud.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 51177ffe16f179..a3522b70218d3a 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -2166,7 +2166,7 @@ static struct worker *create_worker(struct worker_pool *pool) { struct worker *worker; int id; - char id_buf[16]; + char id_buf[23]; /* ID is needed to determine kthread name */ id = ida_alloc(&pool->worker_ida, GFP_KERNEL); |