diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2024-04-29 13:28:41 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-04-30 00:14:48 +0900 |
| commit | 97f3d8630d9394e3ea0770f62af94e441da1bf1e (patch) | |
| tree | bfb47ede6ba7d0ed9eb5d7b8a78bdf02aab96a11 | |
| parent | 248e6c61f009de1bc93d399e1f1d1a72887418e2 (diff) | |
| download | ci-20240429_wsa_renesas_spi_use_time_left_instead_of_timeout_with_wait_for__functions.tar.gz | |
spi: xlp: use 'time_left' variable with wait_for_completion_timeout()20240429_wsa_renesas_spi_use_time_left_instead_of_timeout_with_wait_for__functions
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:
timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.
Fix to the proper variable type 'unsigned long' while here.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429112843.67628-9-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-xlp.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c index 49302364b7bdad..2fec18b6844978 100644 --- a/drivers/spi/spi-xlp.c +++ b/drivers/spi/spi-xlp.c @@ -270,7 +270,7 @@ static int xlp_spi_xfer_block(struct xlp_spi_priv *xs, const unsigned char *tx_buf, unsigned char *rx_buf, int xfer_len, int cmd_cont) { - int timeout; + unsigned long time_left; u32 intr_mask = 0; xs->tx_buf = tx_buf; @@ -299,11 +299,11 @@ static int xlp_spi_xfer_block(struct xlp_spi_priv *xs, intr_mask |= XLP_SPI_INTR_DONE; xlp_spi_reg_write(xs, xs->cs, XLP_SPI_INTR_EN, intr_mask); - timeout = wait_for_completion_timeout(&xs->done, - msecs_to_jiffies(1000)); + time_left = wait_for_completion_timeout(&xs->done, + msecs_to_jiffies(1000)); /* Disable interrupts */ xlp_spi_reg_write(xs, xs->cs, XLP_SPI_INTR_EN, 0x0); - if (!timeout) { + if (!time_left) { dev_err(&xs->dev, "xfer timedout!\n"); goto out; } |