diff options
| author | Vitaly Chikunov <vt@altlinux.org> | 2023-10-24 05:29:40 +0300 |
|---|---|---|
| committer | Vitaly Chikunov <vt@altlinux.org> | 2023-10-25 22:27:00 +0300 |
| commit | 0905f371046906353108ded80b1564f8188ce85e (patch) | |
| tree | e225f0501ee59f6fd81165bccfe6d6ac6e89b411 | |
| parent | c11e22e92f3796f21eb15eb6ddc1614d9fa4f99d (diff) | |
| download | fio-0905f371046906353108ded80b1564f8188ce85e.tar.gz | |
nfs: Fix incorrect engine registering for '--enghelp' list
`ioengine` from `nfs` (internal) engine is incorrectly exported thus
overriding its value in constructor callbacks of other external engines,
that are used for registering engine for listing with `--enghelp`.
Because flist is unsafe to double adding it also making `engine_list` to
become corrupt and causing infinite loop or abnormal list termination
when printing engine list.
Issue: https://github.com/axboe/fio/issues/1655
Fixes: 9326926b ("NFS engine")
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
| -rw-r--r-- | engines/nfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/engines/nfs.c b/engines/nfs.c index 970962a3f..ce748d144 100644 --- a/engines/nfs.c +++ b/engines/nfs.c @@ -308,7 +308,7 @@ static int fio_libnfs_close(struct thread_data *td, struct fio_file *f) return ret; } -struct ioengine_ops ioengine = { +static struct ioengine_ops ioengine = { .name = "nfs", .version = FIO_IOOPS_VERSION, .setup = fio_libnfs_setup, |