diff options
| author | Johan Hovold <johan@kernel.org> | 2018-07-04 17:02:17 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2018-07-06 10:32:28 +0200 |
| commit | 794744abfffef8b1f3c0c8a4896177d6d13d653d (patch) | |
| tree | 8bb8493d4aeccbac29c17191f6ef9998d68036d0 | |
| parent | 01b3cdfca263a17554f7b249d20a247b2a751521 (diff) | |
| download | linux-lora-794744abfffef8b1f3c0c8a4896177d6d13d653d.tar.gz | |
USB: serial: mos7840: fix status-register error handling
Add missing transfer-length sanity check to the status-register
completion handler to avoid leaking bits of uninitialised slab data to
user space.
Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Cc: stable <stable@vger.kernel.org> # 2.6.19
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index fdceb46d9fc61a..b580b4c7fa488b 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -468,6 +468,9 @@ static void mos7840_control_callback(struct urb *urb) } dev_dbg(dev, "%s urb buffer size is %d\n", __func__, urb->actual_length); + if (urb->actual_length < 1) + goto out; + dev_dbg(dev, "%s mos7840_port->MsrLsr is %d port %d\n", __func__, mos7840_port->MsrLsr, mos7840_port->port_num); data = urb->transfer_buffer; |