diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-07-28 01:13:29 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-07-27 16:35:39 -0700 |
| commit | 6d00680de2c8a517f2b6b5853588786ed92fae93 (patch) | |
| tree | ad8f6b41376588a32046370fdae5848de5e63066 /t/test-lib.sh | |
| parent | 6a475b71f8c4ce708d69fdc9317aefbde3769e25 (diff) | |
| download | git-6d00680de2c8a517f2b6b5853588786ed92fae93.tar.gz | |
test-lib: use $1, not $@ in test_known_broken_{ok,failure}_
Clarify that these two functions never take N arguments, they'll only
ever receive one. They've needlessly used $@ over $1 since
41ac414ea2b (Sane use of test_expect_failure, 2008-02-01).
In the future we might want to pass the test source to these, but now
that's not the case. This preparatory change helps to clarify a
follow-up change.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/test-lib.sh')
| -rw-r--r-- | t/test-lib.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/t/test-lib.sh b/t/test-lib.sh index 7726d1da88..3f11ce3511 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -804,14 +804,14 @@ test_failure_ () { test_known_broken_ok_ () { test_fixed=$(($test_fixed+1)) - say_color error "ok $test_count - $@ # TODO known breakage vanished" - finalize_test_case_output fixed "$@" + say_color error "ok $test_count - $1 # TODO known breakage vanished" + finalize_test_case_output fixed "$1" } test_known_broken_failure_ () { test_broken=$(($test_broken+1)) - say_color warn "not ok $test_count - $@ # TODO known breakage" - finalize_test_case_output broken "$@" + say_color warn "not ok $test_count - $1 # TODO known breakage" + finalize_test_case_output broken "$1" } test_debug () { |