diff options
author | Patrick Steinhardt <ps@pks.im> | 2024-01-11 11:06:52 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2024-01-11 12:10:59 -0800 |
commit | 85e72be15d9eed0fc9373a8f4f8bc0fcc75041b3 (patch) | |
tree | 80f5aade2966ef5a8bedb62cee6b9c44c9aa5974 /reftable | |
parent | 6fdfaf15a0c60572ac58c979a46e34634051e12f (diff) | |
download | git-85e72be15d9eed0fc9373a8f4f8bc0fcc75041b3.tar.gz |
reftable/blocksource: refactor code to match our coding style
Refactor `reftable_block_source_from_file()` to match our coding style
better.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'reftable')
-rw-r--r-- | reftable/blocksource.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/reftable/blocksource.c b/reftable/blocksource.c index a1ea304429..1e2fb5e9fd 100644 --- a/reftable/blocksource.c +++ b/reftable/blocksource.c @@ -125,24 +125,23 @@ static struct reftable_block_source_vtable file_vtable = { int reftable_block_source_from_file(struct reftable_block_source *bs, const char *name) { - struct stat st = { 0 }; - int err = 0; - int fd = open(name, O_RDONLY); - struct file_block_source *p = NULL; + struct file_block_source *p; + struct stat st; + int fd; + + fd = open(name, O_RDONLY); if (fd < 0) { - if (errno == ENOENT) { + if (errno == ENOENT) return REFTABLE_NOT_EXIST_ERROR; - } return -1; } - err = fstat(fd, &st); - if (err < 0) { + if (fstat(fd, &st) < 0) { close(fd); return REFTABLE_IO_ERROR; } - p = reftable_calloc(sizeof(struct file_block_source)); + p = reftable_calloc(sizeof(*p)); p->size = st.st_size; p->fd = fd; |