summaryrefslogtreecommitdiffstats
path: root/SubmittingPatches.html
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2020-11-02 14:05:05 -0800
committerJunio C Hamano <gitster@pobox.com>2020-11-02 14:05:05 -0800
commitdf3d3cddff51ef14a454394a9977e899f72b8244 (patch)
treeb6f9a3c1f550494dd1bb439f3b1cb05067ce621a /SubmittingPatches.html
parentb8e9cfb64bf7192e3861ff1b72d169e7d1554be9 (diff)
downloadgit-htmldocs-df3d3cddff51ef14a454394a9977e899f72b8244.tar.gz
Autogenerated HTML docs for v2.29.2-154-g7f7eb
Diffstat (limited to 'SubmittingPatches.html')
-rw-r--r--SubmittingPatches.html44
1 files changed, 24 insertions, 20 deletions
diff --git a/SubmittingPatches.html b/SubmittingPatches.html
index ec95231ae..62e15bc1b 100644
--- a/SubmittingPatches.html
+++ b/SubmittingPatches.html
@@ -946,7 +946,7 @@ thread to help readers find all parts of the series. To that end,
send them as replies to either an additional "cover letter" message
(see below), the first patch, or the respective preceding patch.</p></div>
<div class="paragraph"><p>If your log message (including your name on the
-Signed-off-by line) is not writable in ASCII, make sure that
+<code>Signed-off-by</code> trailer) is not writable in ASCII, make sure that
you send off a message in the correct encoding.</p></div>
<div class="admonitionblock">
<table><tr>
@@ -970,7 +970,7 @@ previously sent.</p></div>
<div class="paragraph"><p>The <code>git format-patch</code> command follows the best current practice to
format the body of an e-mail message. At the beginning of the
patch should come your commit message, ending with the
-Signed-off-by: lines, and a line that consists of three dashes,
+<code>Signed-off-by</code> trailers, and a line that consists of three dashes,
followed by the diffstat information and the patch itself. If
you are forwarding a patch from somebody else, optionally, at
the beginning of the e-mail message just before the commit
@@ -1016,22 +1016,21 @@ people who are involved in the area you are touching (the <code>git
contacts</code> command in <code>contrib/contacts/</code> can help to
identify them), to solicit comments and reviews.</p></div>
<div class="paragraph"><p>After the list reached a consensus that it is a good idea to apply the
-patch, re-send it with "To:" set to the maintainer<span class="footnote"><br />[The current maintainer: <a href="mailto:gitster@pobox.com">gitster@pobox.com</a>]<br /></span> and "cc:" the
-list<span class="footnote"><br />[The mailing list: <a href="mailto:git@vger.kernel.org">git@vger.kernel.org</a>]<br /></span> for inclusion.</p></div>
+patch, re-send it with "To:" set to the maintainer<span class="footnote"><br />[The current maintainer: <a href="mailto:gitster@pobox.com">gitster@pobox.com</a>]<br /></span>
+and "cc:" the list<span class="footnote"><br />[The mailing list: <a href="mailto:git@vger.kernel.org">git@vger.kernel.org</a>]<br /></span> for inclusion. This is especially relevant
+when the maintainer did not heavily participate in the discussion and
+instead left the review to trusted others.</p></div>
<div class="paragraph"><p>Do not forget to add trailers such as <code>Acked-by:</code>, <code>Reviewed-by:</code> and
<code>Tested-by:</code> lines as necessary to credit people who helped your
-patch.</p></div>
+patch, and "cc:" them when sending such a final version for inclusion.</p></div>
</div>
<div class="sect2">
-<h3 id="sign-off">Certify your work by adding your "Signed-off-by: " line</h3>
-<div class="paragraph"><p>To improve tracking of who did what, we&#8217;ve borrowed the
-"sign-off" procedure from the Linux kernel project on patches
-that are being emailed around. Although core Git is a lot
-smaller project it is a good discipline to follow it.</p></div>
-<div class="paragraph"><p>The sign-off is a simple line at the end of the explanation for
-the patch, which certifies that you wrote it or otherwise have
-the right to pass it on as an open-source patch. The rules are
-pretty simple: if you can certify the below D-C-O:</p></div>
+<h3 id="sign-off">Certify your work by adding your <code>Signed-off-by</code> trailer</h3>
+<div class="paragraph"><p>To improve tracking of who did what, we ask you to certify that you
+wrote the patch or have the right to pass it on under the same license
+as ours, by "signing off" your patch. Without sign-off, we cannot
+accept your patches.</p></div>
+<div class="paragraph"><p>If you can certify the below D-C-O:</p></div>
<div class="quoteblock" id="dco">
<div class="title">Developer&#8217;s Certificate of Origin 1.1</div>
<div class="content">
@@ -1075,19 +1074,24 @@ I understand and agree that this project and the contribution
</div>
<div class="attribution">
</div></div>
-<div class="paragraph"><p>then you just add a line saying</p></div>
+<div class="paragraph"><p>you add a "Signed-off-by" trailer to your commit, that looks like
+this:</p></div>
<div class="literalblock">
<div class="content">
<pre><code> Signed-off-by: Random J Developer &lt;random@developer.example.org&gt;</code></pre>
</div></div>
-<div class="paragraph"><p>This line can be automatically added by Git if you run the git-commit
-command with the -s option.</p></div>
-<div class="paragraph"><p>Notice that you can place your own Signed-off-by: line when
+<div class="paragraph"><p>This line can be added by Git if you run the git-commit command with
+the -s option.</p></div>
+<div class="paragraph"><p>Notice that you can place your own <code>Signed-off-by</code> trailer when
forwarding somebody else&#8217;s patch with the above rules for
D-C-O. Indeed you are encouraged to do so. Do not forget to
place an in-body "From: " line at the beginning to properly attribute
the change to its true author (see (2) above).</p></div>
-<div class="paragraph" id="real-name"><p>Also notice that a real name is used in the Signed-off-by: line. Please
+<div class="paragraph"><p>This procedure originally came from the Linux kernel project, so our
+rule is quite similar to theirs, but what exactly it means to sign-off
+your patch differs from project to project, so it may be different
+from that of the project you are accustomed to.</p></div>
+<div class="paragraph" id="real-name"><p>Also notice that a real name is used in the <code>Signed-off-by</code> trailer. Please
don&#8217;t hide your real name.</p></div>
<div class="paragraph" id="commit-trailers"><p>If you like, you can put extra tags at the end:</p></div>
<div class="olist arabic"><ol class="arabic">
@@ -1389,7 +1393,7 @@ this problem around.</p></div>
<div id="footer">
<div id="footer-text">
Last updated
- 2020-10-19 10:37:03 PDT
+ 2020-11-02 14:02:24 PST
</div>
</div>
</body>