diff options
| author | Junio C Hamano <gitster@pobox.com> | 2020-11-30 20:47:38 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-11-30 20:47:38 -0800 |
| commit | 8524398ff42cc7af50dc0629cc1d8b2f5f5134c2 (patch) | |
| tree | 9de2e1c9c22efb194895f88148eadc592dbfe2c6 /MyFirstContribution.html | |
| parent | 60fc20f68001dd7cb6f5287277f619b588e6f5f0 (diff) | |
| download | git-htmldocs-8524398ff42cc7af50dc0629cc1d8b2f5f5134c2.tar.gz | |
Autogenerated HTML docs for v2.29.2-435-g72ffeb
Diffstat (limited to 'MyFirstContribution.html')
| -rw-r--r-- | MyFirstContribution.html | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/MyFirstContribution.html b/MyFirstContribution.html index 9ad367c9a..ee18e9d1e 100644 --- a/MyFirstContribution.html +++ b/MyFirstContribution.html @@ -1829,10 +1829,22 @@ index 88f126184c..38da593a60 100644 <div class="paragraph"><p>After a few days, you will hopefully receive a reply to your patchset with some
comments. Woohoo! Now you can get back to work.</p></div>
<div class="paragraph"><p>It’s good manners to reply to each comment, notifying the reviewer that you have
-made the change requested, feel the original is better, or that the comment
+made the change suggested, feel the original is better, or that the comment
inspired you to do something a new way which is superior to both the original
and the suggested change. This way reviewers don’t need to inspect your v2 to
figure out whether you implemented their comment or not.</p></div>
+<div class="paragraph"><p>Reviewers may ask you about what you wrote in the patchset, either in
+the proposed commit log message or in the changes themselves. You
+should answer these questions in your response messages, but often the
+reason why reviewers asked these questions to understand what you meant
+to write is because your patchset needed clarification to be understood.</p></div>
+<div class="paragraph"><p>Do not be satisfied by just answering their questions in your response
+and hear them say that they now understand what you wanted to say.
+Update your patches to clarify the points reviewers had trouble with,
+and prepare your v2; the words you used to explain your v1 to answer
+reviewers' questions may be useful thing to use. Your goal is to make
+your v2 clear enough so that it becomes unnecessary for you to give the
+same explanation to the next person who reads it.</p></div>
<div class="paragraph"><p>If you are going to push back on a comment, be polite and explain why you feel
your original is better; be prepared that the reviewer may still disagree with
you, and the rest of the community may weigh in on one side or the other. As
@@ -1900,7 +1912,7 @@ should generate your diffs from <code><topic>..<mybranch></code> and <div id="footer">
<div id="footer-text">
Last updated
- 2020-11-02 14:02:22 PST
+ 2020-11-30 20:44:23 PST
</div>
</div>
</body>
|