diff options
| author | Junio C Hamano <gitster@pobox.com> | 2023-08-04 12:05:22 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-08-04 12:05:22 -0700 |
| commit | 62908fd797899ccb5145cff3b16cc206d83b9b3f (patch) | |
| tree | 141ad97bf44712f0ef6c881af1136aa47839f58a /MyFirstContribution.html | |
| parent | 50a4df08cc234b607ebd8dfa811a68f23ba05fc4 (diff) | |
| download | git-htmldocs-62908fd797899ccb5145cff3b16cc206d83b9b3f.tar.gz | |
Autogenerated HTML docs for v2.42.0-rc0
Diffstat (limited to 'MyFirstContribution.html')
| -rw-r--r-- | MyFirstContribution.html | 39 |
1 files changed, 37 insertions, 2 deletions
diff --git a/MyFirstContribution.html b/MyFirstContribution.html index a97d70315..1224ab484 100644 --- a/MyFirstContribution.html +++ b/MyFirstContribution.html @@ -735,7 +735,7 @@ asciidoc.install(); <body class="article">
<div id="header">
<h1>My First Contribution to the Git Project</h1>
-<span id="revdate">2023-08-02</span>
+<span id="revdate">2023-08-04</span>
</div>
<div id="content">
<div class="sect1">
@@ -1973,6 +1973,41 @@ index 88f126184c..38da593a60 100644 <div class="sect1">
<h2 id="now-what">My Patch Got Emailed - Now What?</h2>
<div class="sectionbody">
+<div class="paragraph"><p>Please give reviewers enough time to process your initial patch before
+sending an updated version. That is, resist the temptation to send a new
+version immediately, because others may have already started reviewing
+your initial version.</p></div>
+<div class="paragraph"><p>While waiting for review comments, you may find mistakes in your initial
+patch, or perhaps realize a different and better way to achieve the goal
+of the patch. In this case you may communicate your findings to other
+reviewers as follows:</p></div>
+<div class="ulist"><ul>
+<li>
+<p>
+If the mistakes you found are minor, send a reply to your patch as if
+ you were a reviewer and mention that you will fix them in an
+ updated version.
+</p>
+</li>
+<li>
+<p>
+On the other hand, if you think you want to change the course so
+ drastically that reviews on the initial patch would be a waste of
+ time (for everyone involved), retract the patch immediately with
+ a reply like "I am working on a much better approach, so please
+ ignore this patch and wait for the updated version."
+</p>
+</li>
+</ul></div>
+<div class="paragraph"><p>Now, the above is a good practice if you sent your initial patch
+prematurely without polish. But a better approach of course is to avoid
+sending your patch prematurely in the first place.</p></div>
+<div class="paragraph"><p>Please be considerate of the time needed by reviewers to examine each
+new version of your patch. Rather than seeing the initial version right
+now (followed by several "oops, I like this version better than the
+previous one" patches over 2 days), reviewers would strongly prefer if a
+single polished version came 2 days later instead, and that version with
+fewer mistakes were the only one they would need to review.</p></div>
<div class="sect2">
<h3 id="reviewing">Responding to Reviews</h3>
<div class="paragraph"><p>After a few days, you will hopefully receive a reply to your patchset with some
@@ -2061,7 +2096,7 @@ should generate your diffs from <code><topic>..<mybranch></code> and <div id="footer">
<div id="footer-text">
Last updated
- 2023-04-17 21:53:20 PDT
+ 2023-08-04 12:03:14 PDT
</div>
</div>
</body>
|