diff options
| author | Matt Fleming <matt.fleming@intel.com> | 2011-08-10 21:15:29 +0100 |
|---|---|---|
| committer | Matt Fleming <matt.fleming@intel.com> | 2011-08-10 21:15:29 +0100 |
| commit | f65ae93ed8d5f19c5064786bfd8d443543529912 (patch) | |
| tree | 165e5aeabf9e1baf77a33d695a99f3537bf13863 | |
| parent | d0efc62a079f7c2de0c9b5acb74515ac44d97f2d (diff) | |
| download | efilinux-f65ae93ed8d5f19c5064786bfd8d443543529912.tar.gz | |
bzimage: Don't call Print() after ExitBootServices()
It is not safe to call Print() after ExitBootServices() because
Print() may allocate memory, which isn't allowed once the boot
services have exited. Maarten observed that calling Print() after boot
services have exited caused his machine to reboot.
Reported-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
| -rw-r--r-- | loaders/bzimage/bzimage.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/loaders/bzimage/bzimage.c b/loaders/bzimage/bzimage.c index 3edf84d..964950e 100644 --- a/loaders/bzimage/bzimage.c +++ b/loaders/bzimage/bzimage.c @@ -366,7 +366,6 @@ again: break; default: - Print(L"Invalid EFI memory descriptor type!\n"); continue; } @@ -387,8 +386,6 @@ again: asm volatile ("lgdt %0" :: "m" (gdt)); kernel_jump(kernel_start, boot_params); - - Print(L"Error: bzImage returned control to efilinux!"); out: return err; } |