diff options
| author | Yannick Fertre <yannick.fertre@st.com> | 2020-01-21 11:14:10 +0100 |
|---|---|---|
| committer | Benjamin Gaignard <benjamin.gaignard@st.com> | 2020-02-04 11:40:32 +0100 |
| commit | a6bd58c51ac43083f3977057a7ad668def55812f (patch) | |
| tree | 1cab9df1c663d826fcd97071b4d19c02561ae5d1 | |
| parent | 544aa6cefb24d75d7316ee3d9bb7865e69c375b6 (diff) | |
| download | linux-n900-a6bd58c51ac43083f3977057a7ad668def55812f.tar.gz | |
drm/stm: ltdc: check crtc state before enabling LIE
Following investigations of a hardware bug, the LIE interrupt
can occur while the display controller is not activated.
LIE interrupt (vblank) don't have to be set if the CRTC is not
enabled.
Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1579601650-7055-1-git-send-email-yannick.fertre@st.com
| -rw-r--r-- | drivers/gpu/drm/stm/ltdc.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 58092b0b888543..8750ee831beabb 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -648,9 +648,14 @@ static const struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = { static int ltdc_crtc_enable_vblank(struct drm_crtc *crtc) { struct ltdc_device *ldev = crtc_to_ltdc(crtc); + struct drm_crtc_state *state = crtc->state; DRM_DEBUG_DRIVER("\n"); - reg_set(ldev->regs, LTDC_IER, IER_LIE); + + if (state->enable) + reg_set(ldev->regs, LTDC_IER, IER_LIE); + else + return -EPERM; return 0; } |