diff options
| author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2024-02-17 16:42:35 +0000 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2024-02-26 22:00:23 +0000 |
| commit | b5b70383ef761a705c78995f9ab92fdf1b4dea03 (patch) | |
| tree | 2ec0514a2a96e5557e422493ce0df72cb58fe788 | |
| parent | d4551c189d6e6a3fcf7f625bd4b273e770fad35a (diff) | |
| download | iio-b5b70383ef761a705c78995f9ab92fdf1b4dea03.tar.gz | |
device property: Move fwnode_handle_put() into property.h
By having this function as static inline in the header, the compiler
is able to see if can optmize the call out if (IS_ERR_OR_NULL(fwnode))
This will allow a simpler DEFINE_FREE() call in the following patch.
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240217164249.921878-2-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| -rw-r--r-- | drivers/base/property.c | 14 | ||||
| -rw-r--r-- | include/linux/property.h | 14 |
2 files changed, 13 insertions, 15 deletions
diff --git a/drivers/base/property.c b/drivers/base/property.c index a1b01ab420528..53e42031c6464 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -924,20 +924,6 @@ struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode) EXPORT_SYMBOL_GPL(fwnode_handle_get); /** - * fwnode_handle_put - Drop reference to a device node - * @fwnode: Pointer to the device node to drop the reference to. - * - * This has to be used when terminating device_for_each_child_node() iteration - * with break or return to prevent stale device node references from being left - * behind. - */ -void fwnode_handle_put(struct fwnode_handle *fwnode) -{ - fwnode_call_void_op(fwnode, put); -} -EXPORT_SYMBOL_GPL(fwnode_handle_put); - -/** * fwnode_device_is_available - check if a device is available for use * @fwnode: Pointer to the fwnode of the device. * diff --git a/include/linux/property.h b/include/linux/property.h index e6516d0b7d52a..151bcab4f92a1 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -187,7 +187,19 @@ struct fwnode_handle *device_get_named_child_node(const struct device *dev, const char *childname); struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode); -void fwnode_handle_put(struct fwnode_handle *fwnode); + +/** + * fwnode_handle_put - Drop reference to a device node + * @fwnode: Pointer to the device node to drop the reference to. + * + * This has to be used when terminating device_for_each_child_node() iteration + * with break or return to prevent stale device node references from being left + * behind. + */ +static inline void fwnode_handle_put(struct fwnode_handle *fwnode) +{ + fwnode_call_void_op(fwnode, put); +} int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index); int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name); |