diff options
| author | William Breathitt Gray <william.gray@linaro.org> | 2023-04-06 10:40:12 -0400 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2023-04-10 12:26:33 +0100 |
| commit | 46a4cac7f841a2a2cb397bcb2fd24324004c853e (patch) | |
| tree | b6810c854dcf84e1bd53c663407159ee5d1dfda4 | |
| parent | 4f9b80aefb9e2f542a49d9ec087cf5919730e1dd (diff) | |
| download | iio-46a4cac7f841a2a2cb397bcb2fd24324004c853e.tar.gz | |
iio: addac: stx104: Use define rather than hardcoded limit for write val
The DAC register is 16 bits wide, so the value passed by write_raw()
should be checked against that limit. Rather than hardcoding the 16-bit
maximum value limit, use a define to improve readability and make the
intention of the code clearer. The explicit cast is also avoided by
instead explicitly checking for negative values.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
Link: https://lore.kernel.org/r/4c9f4f1b4a270d133be70c82a091351b531b5e3e.1680790580.git.william.gray@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| -rw-r--r-- | drivers/iio/addac/stx104.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/addac/stx104.c b/drivers/iio/addac/stx104.c index 8730b79e921c8..0ed5f71b18cba 100644 --- a/drivers/iio/addac/stx104.c +++ b/drivers/iio/addac/stx104.c @@ -13,6 +13,7 @@ #include <linux/ioport.h> #include <linux/isa.h> #include <linux/kernel.h> +#include <linux/limits.h> #include <linux/module.h> #include <linux/moduleparam.h> #include <linux/mutex.h> @@ -181,8 +182,7 @@ static int stx104_write_raw(struct iio_dev *indio_dev, return 0; case IIO_CHAN_INFO_RAW: if (chan->output) { - /* DAC can only accept up to a 16-bit value */ - if ((unsigned int)val > 65535) + if (val < 0 || val > U16_MAX) return -EINVAL; mutex_lock(&priv->lock); |