diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-19 00:53:42 +0100 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2023-05-30 18:33:25 +0200 |
| commit | a3ce8c8ffb6fdee842b703da78bd81eac0f16d71 (patch) | |
| tree | 1088c41c3786963df8687f3152b0d5a8a6ca2618 | |
| parent | 4b88b6e1c4ec832b02a65b51489692b58d2c6f84 (diff) | |
| download | iio-a3ce8c8ffb6fdee842b703da78bd81eac0f16d71.tar.gz | |
fbdev: broadsheetfb: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
| -rw-r--r-- | drivers/video/fbdev/broadsheetfb.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/video/fbdev/broadsheetfb.c b/drivers/video/fbdev/broadsheetfb.c index 55e62dd96f9be..b518cacbf7cd9 100644 --- a/drivers/video/fbdev/broadsheetfb.c +++ b/drivers/video/fbdev/broadsheetfb.c @@ -1193,7 +1193,7 @@ err: } -static int broadsheetfb_remove(struct platform_device *dev) +static void broadsheetfb_remove(struct platform_device *dev) { struct fb_info *info = platform_get_drvdata(dev); @@ -1209,12 +1209,11 @@ static int broadsheetfb_remove(struct platform_device *dev) module_put(par->board->owner); framebuffer_release(info); } - return 0; } static struct platform_driver broadsheetfb_driver = { .probe = broadsheetfb_probe, - .remove = broadsheetfb_remove, + .remove_new = broadsheetfb_remove, .driver = { .name = "broadsheetfb", }, |