diff options
| author | Tzung-Bi Shih <tzungbi@kernel.org> | 2023-03-10 12:01:32 +0800 |
|---|---|---|
| committer | Tzung-Bi Shih <tzungbi@kernel.org> | 2023-03-15 13:59:31 +0800 |
| commit | e97976e7ffaa778ff85683da1cc45a776c6bc2fa (patch) | |
| tree | 753b8e0bce11bda470bf8b6587be70f6de2995b8 | |
| parent | 1f6fb6baf29d9dd3c5eedba07a746f4d10fb99de (diff) | |
| download | cros-ec-tests-e97976e7ffaa778ff85683da1cc45a776c6bc2fa.tar.gz | |
helpers/mcu: fix ResourceWarning on /dev/cros_ec
Some errors have been revealed after the runner is-a TextTestRunner.
Fix the following warning:
> ResourceWarning: unclosed file <_io.TextIOWrapper name='/dev/cros_ec'
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
| -rw-r--r-- | cros/helpers/mcu.py | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/cros/helpers/mcu.py b/cros/helpers/mcu.py index 36d125b..a454d9f 100644 --- a/cros/helpers/mcu.py +++ b/cros/helpers/mcu.py @@ -112,8 +112,6 @@ def is_feature_supported(feature): global ECFEATURES if ECFEATURES == -1: - fd = open("/dev/cros_ec", "r") - param = ec_params_get_features() response = ec_response_get_features() @@ -124,11 +122,10 @@ def is_feature_supported(feature): cmd.outsize = sizeof(response) memmove(addressof(cmd.data), addressof(param), cmd.outsize) - fcntl.ioctl(fd, EC_DEV_IOCXCMD, cmd) + with open("/dev/cros_ec", "r") as fh: + fcntl.ioctl(fh, EC_DEV_IOCXCMD, cmd) memmove(addressof(response), addressof(cmd.data), cmd.outsize) - fd.close() - if cmd.result == 0: ECFEATURES = response.out_data else: |