diff options
| author | Tzung-Bi Shih <tzungbi@kernel.org> | 2023-03-21 16:00:31 +0800 |
|---|---|---|
| committer | Tzung-Bi Shih <tzungbi@kernel.org> | 2023-03-21 17:32:41 +0800 |
| commit | 67fd19a89026c99c28ef9471c0178f765363ae97 (patch) | |
| tree | 8d9787f7e459a989ed5c118a4c3165592de5e6b6 | |
| parent | 8ff97231dc870083606b04ecbdf95f3c217757cc (diff) | |
| download | cros-ec-tests-67fd19a89026c99c28ef9471c0178f765363ae97.tar.gz | |
helpers/mcu: simplify check_mcu_reboot_rw()
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
| -rw-r--r-- | cros/helpers/mcu.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/cros/helpers/mcu.py b/cros/helpers/mcu.py index 1bef50a..69b6503 100644 --- a/cros/helpers/mcu.py +++ b/cros/helpers/mcu.py @@ -203,8 +203,9 @@ def mcu_get_version(name): def check_mcu_reboot_rw(s, name): - if not os.path.exists(os.path.join("/dev", name)): - s.skipTest(f"MCU {name} not present") + devpath = os.path.join("/dev", name) + if not os.path.exists(devpath): + s.skipTest(f"MCU {name} not found") cmd = cros_ec_command() cmd.version = 0 @@ -212,7 +213,7 @@ def check_mcu_reboot_rw(s, name): cmd.insize = 0 cmd.outsize = 0 - with open(os.path.join("/dev", name)) as fh: + with open(devpath) as fh: fcntl.ioctl(fh, EC_DEV_IOCXCMD, cmd) response = mcu_get_version(name) |