From 73ac9c192d058712993f9941927c924f2e206168 Mon Sep 17 00:00:00 2001 From: "Steven Rostedt (Google)" Date: Thu, 11 Jan 2024 17:38:09 -0500 Subject: libtracefs: Fix tracefs_instance_reset() of triggers The clearing of triggers may require a few loops as the order of the clearing is important. Some triggers rely on other triggers to be cleared before they can be cleared. The tracefs_instance_reset() will loop over all the triggers, clearing them one at a time, and restart from the top again if not all the triggers were cleared. This guarantees that the triggers will have other triggers cleared first if they depend on them to be cleared. The "file" string used to clear the trigger wasn't updated to equal the next file in the list, so it was stale. Link: https://lore.kernel.org/linux-trace-devel/20240111173809.7d5462e8@gandalf.local.home Fixes: 93e20af8 ("libtracefs: Fix tracefs_instance_reset to clear synthetic events") Signed-off-by: Steven Rostedt (Google) --- src/tracefs-instance.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c index 0ee0225..9a26708 100644 --- a/src/tracefs-instance.c +++ b/src/tracefs-instance.c @@ -1539,6 +1539,7 @@ void tracefs_instance_reset(struct tracefs_instance *instance) list_size = tracefs_list_size(file_list); file_list = NULL; for (i = 0; list[i]; i++) { + file = list[i]; ret = clear_trigger(file); if (ret) { char **tlist; -- cgit 1.2.3-korg