aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2022-08-11 18:37:26 -0400
committerTheodore Ts'o <tytso@mit.edu>2022-08-11 19:04:09 -0400
commitec30a439282fd4703d302f1f98fbad3ce9f99db2 (patch)
tree99b5440c3996e2c2a36692e4c0101f65e95e759d
parent003125b2f00aed8f0a1d8b5bd80fcbb1e8e2f13e (diff)
downloade2fsprogs-ec30a439282fd4703d302f1f98fbad3ce9f99db2.tar.gz
resize2fs: use ext2fs_get_arrayzero() instead of ext2fs_get_array() + memset()
The use of ext2fs_get_arrayzero() to replace using ext2fs_get_array() + memset() does not result in any functional change, but it (a) is slightly more efficient, and (b) makes it easier for Coverity to avoid signalling a false positive. Addresses-Coverity-Bug: 1500763 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--resize/extent.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/resize/extent.c b/resize/extent.c
index 4177c6f7e..82f69ca8f 100644
--- a/resize/extent.c
+++ b/resize/extent.c
@@ -50,14 +50,12 @@ errcode_t ext2fs_create_extent_table(ext2_extent *ret_extent, __u64 size)
extent->num = 0;
extent->sorted = 1;
- retval = ext2fs_get_array(sizeof(struct ext2_extent_entry),
+ retval = ext2fs_get_arrayzero(sizeof(struct ext2_extent_entry),
extent->size, &extent->list);
if (retval) {
ext2fs_free_mem(&extent);
return retval;
}
- memset(extent->list, 0,
- sizeof(struct ext2_extent_entry) * extent->size);
*ret_extent = extent;
return 0;
}