# This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.492 -> 1.493 # drivers/usb/class/audio.c 1.17 -> 1.18 # drivers/usb/core/hub.c 1.24 -> 1.25 # drivers/usb/core/usb.c 1.42 -> 1.43 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 02/04/16 rusty@rustcorp.com.au 1.493 # [PATCH] USB set-bit takes a long tweaks # # This removes gratuitous & operators in front of USB's # dev->bus->devmap.devicemap and state->unitbitmap, for bitops. # # This just makes it so it doesn't warn when set_bit et. al take a # long... # # No object code changes, # Rusty. # -------------------------------------------- # diff -Nru a/drivers/usb/class/audio.c b/drivers/usb/class/audio.c --- a/drivers/usb/class/audio.c Tue Apr 16 11:35:37 2002 +++ b/drivers/usb/class/audio.c Tue Apr 16 11:35:37 2002 @@ -3523,7 +3523,7 @@ unsigned char *p1; unsigned int i, j; - if (test_and_set_bit(unitid, &state->unitbitmap)) { + if (test_and_set_bit(unitid, state->unitbitmap)) { printk(KERN_INFO "usbaudio: mixer path revisits unit %d\n", unitid); return; } @@ -3613,7 +3613,7 @@ state.buffer = buffer; state.buflen = buflen; state.ctrlif = ctrlif; - set_bit(oterm[3], &state.unitbitmap); /* mark terminal ID as visited */ + set_bit(oterm[3], state.unitbitmap); /* mark terminal ID as visited */ printk(KERN_DEBUG "usbaudio: constructing mixer for Terminal %u type 0x%04x\n", oterm[3], oterm[4] | (oterm[5] << 8)); usb_audio_recurseunit(&state, oterm[7]); diff -Nru a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c --- a/drivers/usb/core/hub.c Tue Apr 16 11:35:37 2002 +++ b/drivers/usb/core/hub.c Tue Apr 16 11:35:37 2002 @@ -1122,7 +1122,7 @@ dev->devpath, sizeof(dev->descriptor), ret); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return -EIO; } @@ -1131,7 +1131,7 @@ if (ret < 0) { err("unable to get configuration (error=%d)", ret); usb_destroy_configuration(dev); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; } diff -Nru a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c --- a/drivers/usb/core/usb.c Tue Apr 16 11:35:37 2002 +++ b/drivers/usb/core/usb.c Tue Apr 16 11:35:37 2002 @@ -1784,7 +1784,7 @@ /* Free the device number and remove the /proc/bus/usb entry */ if (dev->devnum > 0) { - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); usbfs_remove_device(dev); put_device(&dev->dev); } @@ -2434,7 +2434,7 @@ if (err < 0) { err("USB device not accepting new address=%d (error=%d)", dev->devnum, err); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; } @@ -2447,7 +2447,7 @@ err("USB device not responding, giving up (error=%d)", err); else err("USB device descriptor short read (expected %i, got %i)", 8, err); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; } @@ -2462,7 +2462,7 @@ err("USB device descriptor short read (expected %Zi, got %i)", sizeof(dev->descriptor), err); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; } @@ -2471,7 +2471,7 @@ if (err < 0) { err("unable to get device %d configuration (error=%d)", dev->devnum, err); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; } @@ -2481,7 +2481,7 @@ if (err) { err("failed to set device %d default configuration (error=%d)", dev->devnum, err); - clear_bit(dev->devnum, &dev->bus->devmap.devicemap); + clear_bit(dev->devnum, dev->bus->devmap.devicemap); dev->devnum = -1; return 1; }