From: A number of small fixes for the Motorola 68328 setup code: . fix interrupt routine return types to be irqreturn_t . add type specifier to printk calls (from kernel janitors) . rework asm code to be gcc-3.3.x clean --- 25-akpm/arch/m68knommu/platform/68328/config.c | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-) diff -puN arch/m68knommu/platform/68328/config.c~use-irqreturn_t-in-motorola-68328-setup-code arch/m68knommu/platform/68328/config.c --- 25/arch/m68knommu/platform/68328/config.c~use-irqreturn_t-in-motorola-68328-setup-code 2004-04-10 15:19:55.918733792 -0700 +++ 25-akpm/arch/m68knommu/platform/68328/config.c 2004-04-10 15:19:55.922733184 -0700 @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -29,7 +30,7 @@ #include -void BSP_sched_init(void (*timer_routine)(int, void *, struct pt_regs *)) +void BSP_sched_init(irqreturn_t (*timer_routine)(int, void *, struct pt_regs *)) { #ifdef CONFIG_XCOPILOT_BUGS @@ -100,20 +101,18 @@ int BSP_set_clock_mmss (unsigned long no void BSP_reset (void) { local_irq_disable(); - asm volatile (" - moveal #0x10c00000, %a0; - moveb #0, 0xFFFFF300; - moveal 0(%a0), %sp; - moveal 4(%a0), %a0; - jmp (%a0); - "); + asm volatile ("moveal #0x10c00000, %a0;\n\t" + "moveb #0, 0xFFFFF300;\n\t" + "moveal 0(%a0), %sp;\n\t" + "moveal 4(%a0), %a0;\n\t" + "jmp (%a0);"); } void config_BSP(char *command, int len) { - printk("\n68328 support D. Jeff Dionne \n"); - printk("68328 support Kenneth Albanowski \n"); - printk("68328/Pilot support Bernhard Kuhn \n"); + printk(KERN_INFO "\n68328 support D. Jeff Dionne \n"); + printk(KERN_INFO "68328 support Kenneth Albanowski \n"); + printk(KERN_INFO "68328/Pilot support Bernhard Kuhn \n"); mach_sched_init = BSP_sched_init; mach_tick = BSP_tick; @@ -122,4 +121,5 @@ void config_BSP(char *command, int len) mach_hwclk = NULL; mach_set_clock_mmss = NULL; mach_reset = BSP_reset; + *command = '\0'; } _