From: Dave Hansen Bugme bug 4326: http://bugme.osdl.org/show_bug.cgi?id=4326 reports: executing the systemcall readv with Bad argument ->len == -1) it gives out error EFAULT instead of EINVAL Signed-off-by: Andrew Morton --- 25-akpm/fs/read_write.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/read_write.c~undo-do_readv_writev-behavior-change fs/read_write.c --- 25/fs/read_write.c~undo-do_readv_writev-behavior-change Thu Mar 31 15:18:29 2005 +++ 25-akpm/fs/read_write.c Thu Mar 31 15:18:29 2005 @@ -467,10 +467,10 @@ static ssize_t do_readv_writev(int type, void __user *buf = iov[seg].iov_base; ssize_t len = (ssize_t)iov[seg].iov_len; - if (unlikely(!access_ok(vrfy_dir(type), buf, len))) - goto Efault; if (len < 0) /* size_t not fitting an ssize_t .. */ goto out; + if (unlikely(!access_ok(vrfy_dir(type), buf, len))) + goto Efault; tot_len += len; if ((ssize_t)tot_len < 0) /* maths overflow on the ssize_t */ goto out; _