From: Rajesh Shah With root bridge and pci bridge hot-plug, new buses and devices can be added or removed at run time. Protect the pci bus and device lists with the pci lock when doing so. Signed-off-by: Rajesh Shah Signed-off-by: Andrew Morton --- 25-akpm/drivers/pci/probe.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletion(-) diff -puN drivers/pci/probe.c~acpi-bridge-hotadd-take-the-pci-lock-when-modifying-pci-bus-or-device-lists drivers/pci/probe.c --- 25/drivers/pci/probe.c~acpi-bridge-hotadd-take-the-pci-lock-when-modifying-pci-bus-or-device-lists 2005-03-18 15:38:51.000000000 -0800 +++ 25-akpm/drivers/pci/probe.c 2005-03-18 15:38:51.000000000 -0800 @@ -8,6 +8,7 @@ #include #include #include +#include "pci.h" #undef DEBUG @@ -376,8 +377,11 @@ struct pci_bus * __devinit pci_add_new_b struct pci_bus *child; child = pci_alloc_child_bus(parent, dev, busnr); - if (child) + if (child) { + spin_lock(&pci_bus_lock); list_add_tail(&child->node, &parent->children); + spin_unlock(&pci_bus_lock); + } return child; } @@ -767,7 +771,9 @@ pci_scan_single_device(struct pci_bus *b * and the bus list for fixup functions, etc. */ INIT_LIST_HEAD(&dev->global_list); + spin_lock(&pci_bus_lock); list_add_tail(&dev->bus_list, &bus->devices); + spin_unlock(&pci_bus_lock); return dev; } @@ -888,7 +894,9 @@ struct pci_bus * __devinit pci_scan_bus_ DBG("PCI: Bus %04x:%02x already known\n", pci_domain_nr(b), bus); goto err_out; } + spin_lock(&pci_bus_lock); list_add_tail(&b->node, &pci_root_buses); + spin_unlock(&pci_bus_lock); memset(dev, 0, sizeof(*dev)); dev->parent = parent; @@ -930,7 +938,9 @@ class_dev_create_file_err: class_dev_reg_err: device_unregister(dev); dev_reg_err: + spin_lock(&pci_bus_lock); list_del(&b->node); + spin_unlock(&pci_bus_lock); err_out: kfree(dev); kfree(b); _