From: Domen Puncer Make code more readable with list_for_each_reverse. Signed-off-by: Domen Puncer Signed-off-by: Maximilian Attems Acked-by: Jeff Dike Signed-off-by: Domen Puncer Signed-off-by: Andrew Morton --- 25-akpm/arch/um/drivers/chan_kern.c | 4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -puN arch/um/drivers/chan_kern.c~list_for_each_entry-arch-um-drivers-chan_kernc arch/um/drivers/chan_kern.c --- 25/arch/um/drivers/chan_kern.c~list_for_each_entry-arch-um-drivers-chan_kernc 2005-03-06 19:57:50.000000000 -0800 +++ 25-akpm/arch/um/drivers/chan_kern.c 2005-03-06 19:57:50.000000000 -0800 @@ -218,7 +218,6 @@ void enable_chan(struct list_head *chans void close_chan(struct list_head *chans) { - struct list_head *ele; struct chan *chan; /* Close in reverse order as open in case more than one of them @@ -226,8 +225,7 @@ void close_chan(struct list_head *chans) * state. Then, the first one opened will have the original state, * so it must be the last closed. */ - for(ele = chans->prev; ele != chans; ele = ele->prev){ - chan = list_entry(ele, struct chan, list); + list_for_each_entry_reverse(chan, chans, list) { if(!chan->opened) continue; if(chan->ops->close != NULL) (*chan->ops->close)(chan->fd, chan->data); _