From: William Lee Irwin III It looks like no one listened to my commentary on the set_pgd() patch. Remove pointless #ifdef, pointless set_pgd(), and a mysterious line full of nothing but whitespace after the #endif, and update commentary. arch/i386/mm/fault.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff -puN arch/i386/mm/fault.c~nobody-listens-to-wli arch/i386/mm/fault.c --- 25/arch/i386/mm/fault.c~nobody-listens-to-wli 2003-05-05 19:04:36.000000000 -0700 +++ 25-akpm/arch/i386/mm/fault.c 2003-05-05 19:04:36.000000000 -0700 @@ -330,16 +330,12 @@ vmalloc_fault: if (!pgd_present(*pgd_k)) goto no_context; + /* - * kernel pmd pages are shared among all processes - * with PAE on. Since vmalloc pages are always - * in the kernel area, this will always be a - * waste with PAE on. + * set_pgd(pgd, *pgd_k); here would be useless on PAE + * and redundant with the set_pmd() on non-PAE. */ -#ifndef CONFIG_X86_PAE - set_pgd(pgd, *pgd_k); -#endif - + pmd = pmd_offset(pgd, address); pmd_k = pmd_offset(pgd_k, address); if (!pmd_present(*pmd_k)) _