sphinx.addnodesdocument)}( rawsourcechildren]( translations LanguagesNode)}(hhh](h pending_xref)}(hhh]docutils.nodesTextChinese (Simplified)}parenthsba attributes}(ids]classes]names]dupnames]backrefs] refdomainstdreftypedoc reftarget*/translations/zh_CN/process/maintainer-tipmodnameN classnameN refexplicitutagnamehhh ubh)}(hhh]hChinese (Traditional)}hh2sbah}(h]h ]h"]h$]h&] refdomainh)reftypeh+ reftarget*/translations/zh_TW/process/maintainer-tipmodnameN classnameN refexplicituh1hhh ubh)}(hhh]hItalian}hhFsbah}(h]h ]h"]h$]h&] refdomainh)reftypeh+ reftarget*/translations/it_IT/process/maintainer-tipmodnameN classnameN refexplicituh1hhh ubh)}(hhh]hJapanese}hhZsbah}(h]h ]h"]h$]h&] refdomainh)reftypeh+ reftarget*/translations/ja_JP/process/maintainer-tipmodnameN classnameN refexplicituh1hhh ubh)}(hhh]hKorean}hhnsbah}(h]h ]h"]h$]h&] refdomainh)reftypeh+ reftarget*/translations/ko_KR/process/maintainer-tipmodnameN classnameN refexplicituh1hhh ubh)}(hhh]hSpanish}hhsbah}(h]h ]h"]h$]h&] refdomainh)reftypeh+ reftarget*/translations/sp_SP/process/maintainer-tipmodnameN classnameN refexplicituh1hhh ubeh}(h]h ]h"]h$]h&]current_languageEnglishuh1h hh _documenthsourceNlineNubhcomment)}(h SPDX-License-Identifier: GPL-2.0h]h SPDX-License-Identifier: GPL-2.0}hhsbah}(h]h ]h"]h$]h&] xml:spacepreserveuh1hhhhhhD/var/lib/git/docbuild/linux/Documentation/process/maintainer-tip.rsthKubhsection)}(hhh](htitle)}(hThe tip tree handbookh]hThe tip tree handbook}(hhhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhhhhhKubh)}(hhh](h)}(hWhat is the tip tree?h]hWhat is the tip tree?}(hhhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhhhhhKubh paragraph)}(hX The tip tree is a collection of several subsystems and areas of development. The tip tree is both a direct development tree and an aggregation tree for several sub-maintainer trees. The tip tree gitweb URL is: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.gith](hThe tip tree is a collection of several subsystems and areas of development. The tip tree is both a direct development tree and an aggregation tree for several sub-maintainer trees. The tip tree gitweb URL is: }(hhhhhNhNubh reference)}(h;https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.gith]h;https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git}(hhhhhNhNubah}(h]h ]h"]h$]h&]refurihuh1hhhubeh}(h]h ]h"]h$]h&]uh1hhhhK hhhhubh)}(h/The tip tree contains the following subsystems:h]h/The tip tree contains the following subsystems:}(hhhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhhhhubh block_quote)}(hX - **x86 architecture** The x86 architecture development takes place in the tip tree except for the x86 KVM and XEN specific parts which are maintained in the corresponding subsystems and routed directly to mainline from there. It's still good practice to Cc the x86 maintainers on x86-specific KVM and XEN patches. Some x86 subsystems have their own maintainers in addition to the overall x86 maintainers. Please Cc the overall x86 maintainers on patches touching files in arch/x86 even when they are not called out by the MAINTAINER file. Note, that ``x86@kernel.org`` is not a mailing list. It is merely a mail alias which distributes mails to the x86 top-level maintainer team. Please always Cc the Linux Kernel mailing list (LKML) ``linux-kernel@vger.kernel.org``, otherwise your mail ends up only in the private inboxes of the maintainers. - **Scheduler** Scheduler development takes place in the -tip tree, in the sched/core branch - with occasional sub-topic trees for work-in-progress patch-sets. - **Locking and atomics** Locking development (including atomics and other synchronization primitives that are connected to locking) takes place in the -tip tree, in the locking/core branch - with occasional sub-topic trees for work-in-progress patch-sets. - **Generic interrupt subsystem and interrupt chip drivers**: - interrupt core development happens in the irq/core branch - interrupt chip driver development also happens in the irq/core branch, but the patches are usually applied in a separate maintainer tree and then aggregated into irq/core - **Time, timers, timekeeping, NOHZ and related chip drivers**: - timekeeping, clocksource core, NTP and alarmtimer development happens in the timers/core branch, but patches are usually applied in a separate maintainer tree and then aggregated into timers/core - clocksource/event driver development happens in the timers/core branch, but patches are mostly applied in a separate maintainer tree and then aggregated into timers/core - **Performance counters core, architecture support and tooling**: - perf core and architecture support development happens in the perf/core branch - perf tooling development happens in the perf tools maintainer tree and is aggregated into the tip tree. - **CPU hotplug core** - **RAS core** Mostly x86-specific RAS patches are collected in the tip ras/core branch. - **EFI core** EFI development in the efi git tree. The collected patches are aggregated in the tip efi/core branch. - **RCU** RCU development happens in the linux-rcu tree. The resulting changes are aggregated into the tip core/rcu branch. - **Various core code components**: - debugobjects - objtool - random bits and pieces h]h bullet_list)}(hhh](h list_item)}(hXO**x86 architecture** The x86 architecture development takes place in the tip tree except for the x86 KVM and XEN specific parts which are maintained in the corresponding subsystems and routed directly to mainline from there. It's still good practice to Cc the x86 maintainers on x86-specific KVM and XEN patches. Some x86 subsystems have their own maintainers in addition to the overall x86 maintainers. Please Cc the overall x86 maintainers on patches touching files in arch/x86 even when they are not called out by the MAINTAINER file. Note, that ``x86@kernel.org`` is not a mailing list. It is merely a mail alias which distributes mails to the x86 top-level maintainer team. Please always Cc the Linux Kernel mailing list (LKML) ``linux-kernel@vger.kernel.org``, otherwise your mail ends up only in the private inboxes of the maintainers. h](h)}(h**x86 architecture**h]hstrong)}(hjh]hx86 architecture}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]uh1hhhhKhjubh)}(hX#The x86 architecture development takes place in the tip tree except for the x86 KVM and XEN specific parts which are maintained in the corresponding subsystems and routed directly to mainline from there. It's still good practice to Cc the x86 maintainers on x86-specific KVM and XEN patches.h]hX%The x86 architecture development takes place in the tip tree except for the x86 KVM and XEN specific parts which are maintained in the corresponding subsystems and routed directly to mainline from there. It’s still good practice to Cc the x86 maintainers on x86-specific KVM and XEN patches.}(hj3hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjubh)}(hSome x86 subsystems have their own maintainers in addition to the overall x86 maintainers. Please Cc the overall x86 maintainers on patches touching files in arch/x86 even when they are not called out by the MAINTAINER file.h]hSome x86 subsystems have their own maintainers in addition to the overall x86 maintainers. Please Cc the overall x86 maintainers on patches touching files in arch/x86 even when they are not called out by the MAINTAINER file.}(hjAhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjubh)}(hX0Note, that ``x86@kernel.org`` is not a mailing list. It is merely a mail alias which distributes mails to the x86 top-level maintainer team. Please always Cc the Linux Kernel mailing list (LKML) ``linux-kernel@vger.kernel.org``, otherwise your mail ends up only in the private inboxes of the maintainers.h](h Note, that }(hjOhhhNhNubhliteral)}(h``x86@kernel.org``h]hx86@kernel.org}(hjYhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjOubh is not a mailing list. It is merely a mail alias which distributes mails to the x86 top-level maintainer team. Please always Cc the Linux Kernel mailing list (LKML) }(hjOhhhNhNubjX)}(h ``linux-kernel@vger.kernel.org``h]hlinux-kernel@vger.kernel.org}(hjkhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjOubhM, otherwise your mail ends up only in the private inboxes of the maintainers.}(hjOhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhKhjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h**Scheduler** Scheduler development takes place in the -tip tree, in the sched/core branch - with occasional sub-topic trees for work-in-progress patch-sets. h](h)}(h **Scheduler**h]j)}(hjh]h Scheduler}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]uh1hhhhK#hjubh)}(hScheduler development takes place in the -tip tree, in the sched/core branch - with occasional sub-topic trees for work-in-progress patch-sets.h]hScheduler development takes place in the -tip tree, in the sched/core branch - with occasional sub-topic trees for work-in-progress patch-sets.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK%hjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hX**Locking and atomics** Locking development (including atomics and other synchronization primitives that are connected to locking) takes place in the -tip tree, in the locking/core branch - with occasional sub-topic trees for work-in-progress patch-sets. h](h)}(h**Locking and atomics**h]j)}(hjh]hLocking and atomics}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]uh1hhhhK)hjubh)}(hLocking development (including atomics and other synchronization primitives that are connected to locking) takes place in the -tip tree, in the locking/core branch - with occasional sub-topic trees for work-in-progress patch-sets.h]hLocking development (including atomics and other synchronization primitives that are connected to locking) takes place in the -tip tree, in the locking/core branch - with occasional sub-topic trees for work-in-progress patch-sets.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK+hjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hX+**Generic interrupt subsystem and interrupt chip drivers**: - interrupt core development happens in the irq/core branch - interrupt chip driver development also happens in the irq/core branch, but the patches are usually applied in a separate maintainer tree and then aggregated into irq/core h](h)}(h;**Generic interrupt subsystem and interrupt chip drivers**:h](j)}(h:**Generic interrupt subsystem and interrupt chip drivers**h]h6Generic interrupt subsystem and interrupt chip drivers}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh:}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhK0hjubj)}(hhh](j)}(h:interrupt core development happens in the irq/core branch h]h)}(h9interrupt core development happens in the irq/core branchh]h9interrupt core development happens in the irq/core branch}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK2hj ubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hinterrupt chip driver development also happens in the irq/core branch, but the patches are usually applied in a separate maintainer tree and then aggregated into irq/core h]h)}(hinterrupt chip driver development also happens in the irq/core branch, but the patches are usually applied in a separate maintainer tree and then aggregated into irq/coreh]hinterrupt chip driver development also happens in the irq/core branch, but the patches are usually applied in a separate maintainer tree and then aggregated into irq/core}(hj&hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK4hj"ubah}(h]h ]h"]h$]h&]uh1jhjubeh}(h]h ]h"]h$]h&]bullet-uh1jhhhK2hjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hX**Time, timers, timekeeping, NOHZ and related chip drivers**: - timekeeping, clocksource core, NTP and alarmtimer development happens in the timers/core branch, but patches are usually applied in a separate maintainer tree and then aggregated into timers/core - clocksource/event driver development happens in the timers/core branch, but patches are mostly applied in a separate maintainer tree and then aggregated into timers/core h](h)}(h=**Time, timers, timekeeping, NOHZ and related chip drivers**:h](j)}(h<**Time, timers, timekeeping, NOHZ and related chip drivers**h]h8Time, timers, timekeeping, NOHZ and related chip drivers}(hjPhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjLubh:}(hjLhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhK8hjHubj)}(hhh](j)}(htimekeeping, clocksource core, NTP and alarmtimer development happens in the timers/core branch, but patches are usually applied in a separate maintainer tree and then aggregated into timers/core h]h)}(htimekeeping, clocksource core, NTP and alarmtimer development happens in the timers/core branch, but patches are usually applied in a separate maintainer tree and then aggregated into timers/coreh]htimekeeping, clocksource core, NTP and alarmtimer development happens in the timers/core branch, but patches are usually applied in a separate maintainer tree and then aggregated into timers/core}(hjohhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK:hjkubah}(h]h ]h"]h$]h&]uh1jhjhubj)}(hclocksource/event driver development happens in the timers/core branch, but patches are mostly applied in a separate maintainer tree and then aggregated into timers/core h]h)}(hclocksource/event driver development happens in the timers/core branch, but patches are mostly applied in a separate maintainer tree and then aggregated into timers/coreh]hclocksource/event driver development happens in the timers/core branch, but patches are mostly applied in a separate maintainer tree and then aggregated into timers/core}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK>hjubah}(h]h ]h"]h$]h&]uh1jhjhubeh}(h]h ]h"]h$]h&]j@jAuh1jhhhK:hjHubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hX**Performance counters core, architecture support and tooling**: - perf core and architecture support development happens in the perf/core branch - perf tooling development happens in the perf tools maintainer tree and is aggregated into the tip tree. h](h)}(h@**Performance counters core, architecture support and tooling**:h](j)}(h?**Performance counters core, architecture support and tooling**h]h;Performance counters core, architecture support and tooling}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh:}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhKBhjubj)}(hhh](j)}(hOperf core and architecture support development happens in the perf/core branch h]h)}(hNperf core and architecture support development happens in the perf/core branchh]hNperf core and architecture support development happens in the perf/core branch}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKDhjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hhperf tooling development happens in the perf tools maintainer tree and is aggregated into the tip tree. h]h)}(hgperf tooling development happens in the perf tools maintainer tree and is aggregated into the tip tree.h]hgperf tooling development happens in the perf tools maintainer tree and is aggregated into the tip tree.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKGhjubah}(h]h ]h"]h$]h&]uh1jhjubeh}(h]h ]h"]h$]h&]j@jAuh1jhhhKDhjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h**CPU hotplug core** h]h)}(h**CPU hotplug core**h]j)}(hj h]hCPU hotplug core}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhj ubah}(h]h ]h"]h$]h&]uh1hhhhKJhjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hX**RAS core** Mostly x86-specific RAS patches are collected in the tip ras/core branch. h](h)}(h **RAS core**h]j)}(hj-h]hRAS core}(hj/hhhNhNubah}(h]h ]h"]h$]h&]uh1jhj+ubah}(h]h ]h"]h$]h&]uh1hhhhKLhj'ubh)}(hIMostly x86-specific RAS patches are collected in the tip ras/core branch.h]hIMostly x86-specific RAS patches are collected in the tip ras/core branch.}(hjBhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKNhj'ubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(ht**EFI core** EFI development in the efi git tree. The collected patches are aggregated in the tip efi/core branch. h](h)}(h **EFI core**h]j)}(hj\h]hEFI core}(hj^hhhNhNubah}(h]h ]h"]h$]h&]uh1jhjZubah}(h]h ]h"]h$]h&]uh1hhhhKQhjVubh)}(heEFI development in the efi git tree. The collected patches are aggregated in the tip efi/core branch.h]heEFI development in the efi git tree. The collected patches are aggregated in the tip efi/core branch.}(hjqhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKShjVubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h{**RCU** RCU development happens in the linux-rcu tree. The resulting changes are aggregated into the tip core/rcu branch. h](h)}(h**RCU**h]j)}(hjh]hRCU}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]uh1hhhhKVhjubh)}(hqRCU development happens in the linux-rcu tree. The resulting changes are aggregated into the tip core/rcu branch.h]hqRCU development happens in the linux-rcu tree. The resulting changes are aggregated into the tip core/rcu branch.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKXhjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h^**Various core code components**: - debugobjects - objtool - random bits and pieces h](h)}(h!**Various core code components**:h](j)}(h **Various core code components**h]hVarious core code components}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh:}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhK[hjubj )}(h5- debugobjects - objtool - random bits and pieces h]j)}(hhh](j)}(h debugobjects h]h)}(h debugobjectsh]h debugobjects}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK]hjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hobjtool h]h)}(hobjtoolh]hobjtool}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK_hjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hrandom bits and pieces h]h)}(hrandom bits and piecesh]hrandom bits and pieces}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKahj ubah}(h]h ]h"]h$]h&]uh1jhjubeh}(h]h ]h"]h$]h&]j@jAuh1jhhhK]hjubah}(h]h ]h"]h$]h&]uh1j hhhK]hjubeh}(h]h ]h"]h$]h&]uh1jhjubeh}(h]h ]h"]h$]h&]j@jAuh1jhhhKhj ubah}(h]h ]h"]h$]h&]uh1j hhhKhhhhubeh}(h]what-is-the-tip-treeah ]h"]what is the tip tree?ah$]h&]uh1hhhhhhhhKubh)}(hhh](h)}(hPatch submission notesh]hPatch submission notes}(hjLhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjIhhhhhKeubh)}(hhh](h)}(hSelecting the tree/branchh]hSelecting the tree/branch}(hj]hhhNhNubah}(h]h ]h"]h$]h&]uh1hhjZhhhhhKhubh)}(hXIn general, development against the head of the tip tree master branch is fine, but for the subsystems which are maintained separately, have their own git tree and are only aggregated into the tip tree, development should take place against the relevant subsystem tree or branch.h]hXIn general, development against the head of the tip tree master branch is fine, but for the subsystems which are maintained separately, have their own git tree and are only aggregated into the tip tree, development should take place against the relevant subsystem tree or branch.}(hjkhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKjhjZhhubh)}(hBug fixes which target mainline should always be applicable against the mainline kernel tree. Potential conflicts against changes which are already queued in the tip tree are handled by the maintainers.h]hBug fixes which target mainline should always be applicable against the mainline kernel tree. Potential conflicts against changes which are already queued in the tip tree are handled by the maintainers.}(hjyhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKohjZhhubeh}(h]selecting-the-tree-branchah ]h"]selecting the tree/branchah$]h&]uh1hhjIhhhhhKhubh)}(hhh](h)}(h Patch subjecth]h Patch subject}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhKtubh)}(hXThe tip tree preferred format for patch subject prefixes is 'subsys/component:', e.g. 'x86/apic:', 'x86/mm/fault:', 'sched/fair:', 'genirq/core:'. Please do not use file names or complete file paths as prefix. 'git log path/to/file' should give you a reasonable hint in most cases.h]hX1The tip tree preferred format for patch subject prefixes is ‘subsys/component:’, e.g. ‘x86/apic:’, ‘x86/mm/fault:’, ‘sched/fair:’, ‘genirq/core:’. Please do not use file names or complete file paths as prefix. ‘git log path/to/file’ should give you a reasonable hint in most cases.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKvhjhhubh)}(hThe condensed patch description in the subject line should start with an uppercase letter and should be written in imperative tone.h]hThe condensed patch description in the subject line should start with an uppercase letter and should be written in imperative tone.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhK|hjhhubeh}(h] patch-subjectah ]h"] patch subjectah$]h&]uh1hhjIhhhhhKtubh)}(hhh](h)}(h Changelogh]h Changelog}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhKubh)}(hdThe general rules about changelogs in the :ref:`Submitting patches guide `, apply.h](h*The general rules about changelogs in the }(hjhhhNhNubh)}(h2:ref:`Submitting patches guide `h]hinline)}(hjh]hSubmitting patches guide}(hjhhhNhNubah}(h]h ](xrefstdstd-refeh"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]refdocprocess/maintainer-tip refdomainjreftyperef refexplicitrefwarn reftargetdescribe_changesuh1hhhhKhjubh, apply.}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhKhjhhubh)}(hXZThe tip tree maintainers set value on following these rules, especially on the request to write changelogs in imperative mood and not impersonating code or the execution of it. This is not just a whim of the maintainers. Changelogs written in abstract words are more precise and tend to be less confusing than those written in the form of novels.h]hXZThe tip tree maintainers set value on following these rules, especially on the request to write changelogs in imperative mood and not impersonating code or the execution of it. This is not just a whim of the maintainers. Changelogs written in abstract words are more precise and tend to be less confusing than those written in the form of novels.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjhhubh)}(hIt's also useful to structure the changelog into several paragraphs and not lump everything together into a single one. A good structure is to explain the context, the problem and the solution in separate paragraphs and this order.h]hIt’s also useful to structure the changelog into several paragraphs and not lump everything together into a single one. A good structure is to explain the context, the problem and the solution in separate paragraphs and this order.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjhhubh)}(hExamples for illustration:h]hExamples for illustration:}(hj(hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjhhubj )}(hXY Example 1:: x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu When a CPU is dying, we cancel the worker and schedule a new worker on a different CPU on the same domain. But if the timer is already about to expire (say 0.99s) then we essentially double the interval. We modify the hot cpu handling to cancel the delayed work on the dying cpu and run the worker immediately on a different cpu in same domain. We do not flush the worker because the MBM overflow worker reschedules the worker on same CPU and scans the domain->cpu_mask to get the domain pointer. Improved version:: x86/intel_rdt/mbm: Fix MBM overflow handler during CPU hotplug When a CPU is dying, the overflow worker is canceled and rescheduled on a different CPU in the same domain. But if the timer is already about to expire this essentially doubles the interval which might result in a non detected overflow. Cancel the overflow worker and reschedule it immediately on a different CPU in the same domain. The work could be flushed as well, but that would reschedule it on the same CPU. Example 2:: time: POSIX CPU timers: Ensure that variable is initialized If cpu_timer_sample_group returns -EINVAL, it will not have written into *sample. Checking for cpu_timer_sample_group's return value precludes the potential use of an uninitialized value of now in the following block. Given an invalid clock_idx, the previous code could otherwise overwrite *oldval in an undefined manner. This is now prevented. We also exploit short-circuiting of && to sample the timer only if the result will actually be used to update *oldval. Improved version:: posix-cpu-timers: Make set_process_cpu_timer() more robust Because the return value of cpu_timer_sample_group() is not checked, compilers and static checkers can legitimately warn about a potential use of the uninitialized variable 'now'. This is not a runtime issue as all call sites hand in valid clock ids. Also cpu_timer_sample_group() is invoked unconditionally even when the result is not used because *oldval is NULL. Make the invocation conditional and check the return value. Example 3:: The entity can also be used for other purposes. Let's rename it to be more generic. Improved version:: The entity can also be used for other purposes. Rename it to be more generic. h](h)}(h Example 1::h]h Example 1:}(hj:hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubh literal_block)}(hX-x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu When a CPU is dying, we cancel the worker and schedule a new worker on a different CPU on the same domain. But if the timer is already about to expire (say 0.99s) then we essentially double the interval. We modify the hot cpu handling to cancel the delayed work on the dying cpu and run the worker immediately on a different cpu in same domain. We do not flush the worker because the MBM overflow worker reschedules the worker on same CPU and scans the domain->cpu_mask to get the domain pointer.h]hX-x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu When a CPU is dying, we cancel the worker and schedule a new worker on a different CPU on the same domain. But if the timer is already about to expire (say 0.99s) then we essentially double the interval. We modify the hot cpu handling to cancel the delayed work on the dying cpu and run the worker immediately on a different cpu in same domain. We do not flush the worker because the MBM overflow worker reschedules the worker on same CPU and scans the domain->cpu_mask to get the domain pointer.}hjJsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubh)}(hImproved version::h]hImproved version:}(hjXhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubjI)}(hXx86/intel_rdt/mbm: Fix MBM overflow handler during CPU hotplug When a CPU is dying, the overflow worker is canceled and rescheduled on a different CPU in the same domain. But if the timer is already about to expire this essentially doubles the interval which might result in a non detected overflow. Cancel the overflow worker and reschedule it immediately on a different CPU in the same domain. The work could be flushed as well, but that would reschedule it on the same CPU.h]hXx86/intel_rdt/mbm: Fix MBM overflow handler during CPU hotplug When a CPU is dying, the overflow worker is canceled and rescheduled on a different CPU in the same domain. But if the timer is already about to expire this essentially doubles the interval which might result in a non detected overflow. Cancel the overflow worker and reschedule it immediately on a different CPU in the same domain. The work could be flushed as well, but that would reschedule it on the same CPU.}hjfsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubh)}(h Example 2::h]h Example 2:}(hjthhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubjI)}(hX time: POSIX CPU timers: Ensure that variable is initialized If cpu_timer_sample_group returns -EINVAL, it will not have written into *sample. Checking for cpu_timer_sample_group's return value precludes the potential use of an uninitialized value of now in the following block. Given an invalid clock_idx, the previous code could otherwise overwrite *oldval in an undefined manner. This is now prevented. We also exploit short-circuiting of && to sample the timer only if the result will actually be used to update *oldval.h]hX time: POSIX CPU timers: Ensure that variable is initialized If cpu_timer_sample_group returns -EINVAL, it will not have written into *sample. Checking for cpu_timer_sample_group's return value precludes the potential use of an uninitialized value of now in the following block. Given an invalid clock_idx, the previous code could otherwise overwrite *oldval in an undefined manner. This is now prevented. We also exploit short-circuiting of && to sample the timer only if the result will actually be used to update *oldval.}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubh)}(hImproved version::h]hImproved version:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubjI)}(hXposix-cpu-timers: Make set_process_cpu_timer() more robust Because the return value of cpu_timer_sample_group() is not checked, compilers and static checkers can legitimately warn about a potential use of the uninitialized variable 'now'. This is not a runtime issue as all call sites hand in valid clock ids. Also cpu_timer_sample_group() is invoked unconditionally even when the result is not used because *oldval is NULL. Make the invocation conditional and check the return value.h]hXposix-cpu-timers: Make set_process_cpu_timer() more robust Because the return value of cpu_timer_sample_group() is not checked, compilers and static checkers can legitimately warn about a potential use of the uninitialized variable 'now'. This is not a runtime issue as all call sites hand in valid clock ids. Also cpu_timer_sample_group() is invoked unconditionally even when the result is not used because *oldval is NULL. Make the invocation conditional and check the return value.}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubh)}(h Example 3::h]h Example 3:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubjI)}(hTThe entity can also be used for other purposes. Let's rename it to be more generic.h]hTThe entity can also be used for other purposes. Let's rename it to be more generic.}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubh)}(hImproved version::h]hImproved version:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj6ubjI)}(hNThe entity can also be used for other purposes. Rename it to be more generic.h]hNThe entity can also be used for other purposes. Rename it to be more generic.}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj6ubeh}(h]h ]h"]h$]h&]uh1j hhhKhjhhubh)}(hFor complex scenarios, especially race conditions and memory ordering issues, it is valuable to depict the scenario with a table which shows the parallelism and the temporal order of events. Here is an example::h]hFor complex scenarios, especially race conditions and memory ordering issues, it is valuable to depict the scenario with a table which shows the parallelism and the temporal order of events. Here is an example:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjhhubjI)}(hXCPU0 CPU1 free_irq(X) interrupt X spin_lock(desc->lock) wake irq thread() spin_unlock(desc->lock) spin_lock(desc->lock) remove action() shutdown_irq() release_resources() thread_handler() spin_unlock(desc->lock) access released resources. ^^^^^^^^^^^^^^^^^^^^^^^^^ synchronize_irq()h]hXCPU0 CPU1 free_irq(X) interrupt X spin_lock(desc->lock) wake irq thread() spin_unlock(desc->lock) spin_lock(desc->lock) remove action() shutdown_irq() release_resources() thread_handler() spin_unlock(desc->lock) access released resources. ^^^^^^^^^^^^^^^^^^^^^^^^^ synchronize_irq()}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhjhhubh)}(hOLockdep provides similar useful output to depict a possible deadlock scenario::h]hNLockdep provides similar useful output to depict a possible deadlock scenario:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhjhhubjI)}(hXdCPU0 CPU1 rtmutex_lock(&rcu->rt_mutex) spin_lock(&rcu->rt_mutex.wait_lock) local_irq_disable() spin_lock(&timer->it_lock) spin_lock(&rcu->mutex.wait_lock) --> Interrupt spin_lock(&timer->it_lock)h]hXdCPU0 CPU1 rtmutex_lock(&rcu->rt_mutex) spin_lock(&rcu->rt_mutex.wait_lock) local_irq_disable() spin_lock(&timer->it_lock) spin_lock(&rcu->mutex.wait_lock) --> Interrupt spin_lock(&timer->it_lock)}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhjhhubeh}(h] changelogah ]h"] changelogah$]h&]uh1hhjIhhhhhKubh)}(hhh](h)}(h!Function references in changelogsh]h!Function references in changelogs}(hj-hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj*hhhhhKubh)}(hWhen a function is mentioned in the changelog, either the text body or the subject line, please use the format 'function_name()'. Omitting the brackets after the function name can be ambiguous::h]hWhen a function is mentioned in the changelog, either the text body or the subject line, please use the format ‘function_name()’. Omitting the brackets after the function name can be ambiguous:}(hj;hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj*hhubjI)}(h~Subject: subsys/component: Make reservation_count static reservation_count is only used in reservation_stats. Make it static.h]h~Subject: subsys/component: Make reservation_count static reservation_count is only used in reservation_stats. Make it static.}hjIsbah}(h]h ]h"]h$]h&]hhuh1jHhhhKhj*hhubh)}(h+The variant with brackets is more precise::h]h*The variant with brackets is more precise:}(hjWhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhKhj*hhubjI)}(hSubject: subsys/component: Make reservation_count() static reservation_count() is only called from reservation_stats(). Make it static.h]hSubject: subsys/component: Make reservation_count() static reservation_count() is only called from reservation_stats(). Make it static.}hjesbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj*hhubeh}(h]!function-references-in-changelogsah ]h"]!function references in changelogsah$]h&]uh1hhjIhhhhhKubh)}(hhh](h)}(hBacktraces in changelogsh]hBacktraces in changelogs}(hj~hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj{hhhhhMubh)}(hSee :ref:`backtraces`.h](hSee }(hjhhhNhNubh)}(h:ref:`backtraces`h]j)}(hjh]h backtraces}(hjhhhNhNubah}(h]h ](jstdstd-refeh"]h$]h&]uh1jhjubah}(h]h ]h"]h$]h&]refdocj refdomainjreftyperef refexplicitrefwarnj backtracesuh1hhhhM hjubh.}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhM hj{hhubeh}(h]backtraces-in-changelogsah ]h"]backtraces in changelogsah$]h&]uh1hhjIhhhhhMubh)}(hhh](h)}(hOrdering of commit tagsh]hOrdering of commit tags}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhM ubh)}(heTo have a uniform view of the commit tags, the tip maintainers use the following tag ordering scheme:h]heTo have a uniform view of the commit tags, the tip maintainers use the following tag ordering scheme:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubj )}(hXy- Fixes: 12+char-SHA1 ("sub/sys: Original subject line") A Fixes tag should be added even for changes which do not need to be backported to stable kernels, i.e. when addressing a recently introduced issue which only affects tip or the current head of mainline. These tags are helpful to identify the original commit and are much more valuable than prominently mentioning the commit which introduced a problem in the text of the changelog itself because they can be automatically extracted. The following example illustrates the difference:: Commit abcdef012345678 ("x86/xxx: Replace foo with bar") left an unused instance of variable foo around. Remove it. Signed-off-by: J.Dev Please say instead:: The recent replacement of foo with bar left an unused instance of variable foo around. Remove it. Fixes: abcdef012345678 ("x86/xxx: Replace foo with bar") Signed-off-by: J.Dev The latter puts the information about the patch into the focus and amends it with the reference to the commit which introduced the issue rather than putting the focus on the original commit in the first place. - Reported-by: ``Reporter `` - Closes: ``URL or Message-ID of the bug report this is fixing`` - Originally-by: ``Original author `` - Suggested-by: ``Suggester `` - Co-developed-by: ``Co-author `` Signed-off-by: ``Co-author `` Note, that Co-developed-by and Signed-off-by of the co-author(s) must come in pairs. - Signed-off-by: ``Author `` The first Signed-off-by (SOB) after the last Co-developed-by/SOB pair is the author SOB, i.e. the person flagged as author by git. - Signed-off-by: ``Patch handler `` SOBs after the author SOB are from people handling and transporting the patch, but were not involved in development. SOB chains should reflect the **real** route a patch took as it was propagated to us, with the first SOB entry signalling primary authorship of a single author. Acks should be given as Acked-by lines and review approvals as Reviewed-by lines. If the handler made modifications to the patch or the changelog, then this should be mentioned **after** the changelog text and **above** all commit tags in the following format:: ... changelog text ends. [ handler: Replaced foo by bar and updated changelog ] First-tag: ..... Note the two empty new lines which separate the changelog text and the commit tags from that notice. If a patch is sent to the mailing list by a handler then the author has to be noted in the first line of the changelog with:: From: Author Changelog text starts here.... so the authorship is preserved. The 'From:' line has to be followed by a empty newline. If that 'From:' line is missing, then the patch would be attributed to the person who sent (transported, handled) it. The 'From:' line is automatically removed when the patch is applied and does not show up in the final git changelog. It merely affects the authorship information of the resulting Git commit. - Tested-by: ``Tester `` - Reviewed-by: ``Reviewer `` - Acked-by: ``Acker `` - Cc: ``cc-ed-person `` If the patch should be backported to stable, then please add a '``Cc: stable@vger.kernel.org``' tag, but do not Cc stable when sending your mail. - Link: ``https://link/to/information`` For referring to an email posted to the kernel mailing lists, please use the lore.kernel.org redirector URL:: Link: https://lore.kernel.org/email-message-id@here This URL should be used when referring to relevant mailing list topics, related patch sets, or other notable discussion threads. A convenient way to associate ``Link:`` trailers with the commit message is to use markdown-like bracketed notation, for example:: A similar approach was attempted before as part of a different effort [1], but the initial implementation caused too many regressions [2], so it was backed out and reimplemented. Link: https://lore.kernel.org/some-msgid@here # [1] Link: https://bugzilla.example.org/bug/12345 # [2] You can also use ``Link:`` trailers to indicate the origin of the patch when applying it to your git tree. In that case, please use the dedicated ``patch.msgid.link`` domain instead of ``lore.kernel.org``. This practice makes it possible for automated tooling to identify which link to use to retrieve the original patch submission. For example:: Link: https://patch.msgid.link/patch-source-message-id@here h]j)}(hhh](j)}(hXqFixes: 12+char-SHA1 ("sub/sys: Original subject line") A Fixes tag should be added even for changes which do not need to be backported to stable kernels, i.e. when addressing a recently introduced issue which only affects tip or the current head of mainline. These tags are helpful to identify the original commit and are much more valuable than prominently mentioning the commit which introduced a problem in the text of the changelog itself because they can be automatically extracted. The following example illustrates the difference:: Commit abcdef012345678 ("x86/xxx: Replace foo with bar") left an unused instance of variable foo around. Remove it. Signed-off-by: J.Dev Please say instead:: The recent replacement of foo with bar left an unused instance of variable foo around. Remove it. Fixes: abcdef012345678 ("x86/xxx: Replace foo with bar") Signed-off-by: J.Dev The latter puts the information about the patch into the focus and amends it with the reference to the commit which introduced the issue rather than putting the focus on the original commit in the first place. h](h)}(h6Fixes: 12+char-SHA1 ("sub/sys: Original subject line")h]h:Fixes: 12+char-SHA1 (“sub/sys: Original subject line”)}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjubh)}(hXA Fixes tag should be added even for changes which do not need to be backported to stable kernels, i.e. when addressing a recently introduced issue which only affects tip or the current head of mainline. These tags are helpful to identify the original commit and are much more valuable than prominently mentioning the commit which introduced a problem in the text of the changelog itself because they can be automatically extracted.h]hXA Fixes tag should be added even for changes which do not need to be backported to stable kernels, i.e. when addressing a recently introduced issue which only affects tip or the current head of mainline. These tags are helpful to identify the original commit and are much more valuable than prominently mentioning the commit which introduced a problem in the text of the changelog itself because they can be automatically extracted.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjubh)}(h2The following example illustrates the difference::h]h1The following example illustrates the difference:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjubjI)}(hCommit abcdef012345678 ("x86/xxx: Replace foo with bar") left an unused instance of variable foo around. Remove it. Signed-off-by: J.Dev h]hCommit abcdef012345678 ("x86/xxx: Replace foo with bar") left an unused instance of variable foo around. Remove it. Signed-off-by: J.Dev }hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjubh)}(hPlease say instead::h]hPlease say instead:}(hj(hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM%hjubjI)}(hThe recent replacement of foo with bar left an unused instance of variable foo around. Remove it. Fixes: abcdef012345678 ("x86/xxx: Replace foo with bar") Signed-off-by: J.Dev h]hThe recent replacement of foo with bar left an unused instance of variable foo around. Remove it. Fixes: abcdef012345678 ("x86/xxx: Replace foo with bar") Signed-off-by: J.Dev }hj6sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM'hjubh)}(hThe latter puts the information about the patch into the focus and amends it with the reference to the commit which introduced the issue rather than putting the focus on the original commit in the first place.h]hThe latter puts the information about the patch into the focus and amends it with the reference to the commit which introduced the issue rather than putting the focus on the original commit in the first place.}(hjDhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM-hjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h*Reported-by: ``Reporter `` h]h)}(h)Reported-by: ``Reporter ``h](h Reported-by: }(hj\hhhNhNubjX)}(h``Reporter ``h]hReporter }(hjdhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj\ubeh}(h]h ]h"]h$]h&]uh1hhhhM1hjXubah}(h]h ]h"]h$]h&]uh1jhjubj)}(h?Closes: ``URL or Message-ID of the bug report this is fixing`` h]h)}(h>Closes: ``URL or Message-ID of the bug report this is fixing``h](hCloses: }(hjhhhNhNubjX)}(h6``URL or Message-ID of the bug report this is fixing``h]h2URL or Message-ID of the bug report this is fixing}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubeh}(h]h ]h"]h$]h&]uh1hhhhM3hj~ubah}(h]h ]h"]h$]h&]uh1jhjubj)}(h:Originally-by: ``Original author `` h]h)}(h9Originally-by: ``Original author ``h](hOriginally-by: }(hjhhhNhNubjX)}(h*``Original author ``h]h&Original author }(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubeh}(h]h ]h"]h$]h&]uh1hhhhM5hjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(h-Suggested-by: ``Suggester `` h]h)}(h,Suggested-by: ``Suggester ``h](hSuggested-by: }(hjhhhNhNubjX)}(h``Suggester ``h]hSuggester }(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubeh}(h]h ]h"]h$]h&]uh1hhhhM7hjubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hCo-developed-by: ``Co-author `` Signed-off-by: ``Co-author `` Note, that Co-developed-by and Signed-off-by of the co-author(s) must come in pairs. h](h)}(h/Co-developed-by: ``Co-author ``h](hCo-developed-by: }(hjhhhNhNubjX)}(h``Co-author ``h]hCo-author }(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubeh}(h]h ]h"]h$]h&]uh1hhhhM9hjubh)}(h-Signed-off-by: ``Co-author ``h](hSigned-off-by: }(hjhhhNhNubjX)}(h``Co-author ``h]hCo-author }(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubeh}(h]h ]h"]h$]h&]uh1hhhhM;hjubh)}(hTNote, that Co-developed-by and Signed-off-by of the co-author(s) must come in pairs.h]hTNote, that Co-developed-by and Signed-off-by of the co-author(s) must come in pairs.}(hj,hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM=hjubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hSigned-off-by: ``Author `` The first Signed-off-by (SOB) after the last Co-developed-by/SOB pair is the author SOB, i.e. the person flagged as author by git. h](h)}(h'Signed-off-by: ``Author ``h](hSigned-off-by: }(hjDhhhNhNubjX)}(h``Author ``h]hAuthor }(hjLhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjDubeh}(h]h ]h"]h$]h&]uh1hhhhM@hj@ubh)}(hThe first Signed-off-by (SOB) after the last Co-developed-by/SOB pair is the author SOB, i.e. the person flagged as author by git.h]hThe first Signed-off-by (SOB) after the last Co-developed-by/SOB pair is the author SOB, i.e. the person flagged as author by git.}(hj`hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMBhj@ubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hXkSigned-off-by: ``Patch handler `` SOBs after the author SOB are from people handling and transporting the patch, but were not involved in development. SOB chains should reflect the **real** route a patch took as it was propagated to us, with the first SOB entry signalling primary authorship of a single author. Acks should be given as Acked-by lines and review approvals as Reviewed-by lines. If the handler made modifications to the patch or the changelog, then this should be mentioned **after** the changelog text and **above** all commit tags in the following format:: ... changelog text ends. [ handler: Replaced foo by bar and updated changelog ] First-tag: ..... Note the two empty new lines which separate the changelog text and the commit tags from that notice. If a patch is sent to the mailing list by a handler then the author has to be noted in the first line of the changelog with:: From: Author Changelog text starts here.... so the authorship is preserved. The 'From:' line has to be followed by a empty newline. If that 'From:' line is missing, then the patch would be attributed to the person who sent (transported, handled) it. The 'From:' line is automatically removed when the patch is applied and does not show up in the final git changelog. It merely affects the authorship information of the resulting Git commit. h](h)}(h/Signed-off-by: ``Patch handler ``h](hSigned-off-by: }(hjxhhhNhNubjX)}(h ``Patch handler ``h]hPatch handler }(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjxubeh}(h]h ]h"]h$]h&]uh1hhhhMEhjtubh)}(hXgSOBs after the author SOB are from people handling and transporting the patch, but were not involved in development. SOB chains should reflect the **real** route a patch took as it was propagated to us, with the first SOB entry signalling primary authorship of a single author. Acks should be given as Acked-by lines and review approvals as Reviewed-by lines.h](hSOBs after the author SOB are from people handling and transporting the patch, but were not involved in development. SOB chains should reflect the }(hjhhhNhNubj)}(h**real**h]hreal}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh route a patch took as it was propagated to us, with the first SOB entry signalling primary authorship of a single author. Acks should be given as Acked-by lines and review approvals as Reviewed-by lines.}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMGhjtubh)}(hIf the handler made modifications to the patch or the changelog, then this should be mentioned **after** the changelog text and **above** all commit tags in the following format::h](h_If the handler made modifications to the patch or the changelog, then this should be mentioned }(hjhhhNhNubj)}(h **after**h]hafter}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh the changelog text and }(hjhhhNhNubj)}(h **above**h]habove}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jhjubh) all commit tags in the following format:}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMNhjtubjI)}(hb... changelog text ends. [ handler: Replaced foo by bar and updated changelog ] First-tag: .....h]hb... changelog text ends. [ handler: Replaced foo by bar and updated changelog ] First-tag: .....}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMRhjtubh)}(hdNote the two empty new lines which separate the changelog text and the commit tags from that notice.h]hdNote the two empty new lines which separate the changelog text and the commit tags from that notice.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMXhjtubh)}(h}If a patch is sent to the mailing list by a handler then the author has to be noted in the first line of the changelog with::h]h|If a patch is sent to the mailing list by a handler then the author has to be noted in the first line of the changelog with:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM[hjtubjI)}(h:From: Author Changelog text starts here....h]h:From: Author Changelog text starts here....}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM^hjtubh)}(hXso the authorship is preserved. The 'From:' line has to be followed by a empty newline. If that 'From:' line is missing, then the patch would be attributed to the person who sent (transported, handled) it. The 'From:' line is automatically removed when the patch is applied and does not show up in the final git changelog. It merely affects the authorship information of the resulting Git commit.h]hXso the authorship is preserved. The ‘From:’ line has to be followed by a empty newline. If that ‘From:’ line is missing, then the patch would be attributed to the person who sent (transported, handled) it. The ‘From:’ line is automatically removed when the patch is applied and does not show up in the final git changelog. It merely affects the authorship information of the resulting Git commit.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMbhjtubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(h$Tested-by: ``Tester `` h]h)}(h#Tested-by: ``Tester ``h](h Tested-by: }(hj6 hhhNhNubjX)}(h``Tester ``h]hTester }(hj> hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj6 ubeh}(h]h ]h"]h$]h&]uh1hhhhMihj2 ubah}(h]h ]h"]h$]h&]uh1jhjubj)}(h*Reviewed-by: ``Reviewer `` h]h)}(h)Reviewed-by: ``Reviewer ``h](h Reviewed-by: }(hj\ hhhNhNubjX)}(h``Reviewer ``h]hReviewer }(hjd hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj\ ubeh}(h]h ]h"]h$]h&]uh1hhhhMkhjX ubah}(h]h ]h"]h$]h&]uh1jhjubj)}(h!Acked-by: ``Acker `` h]h)}(h Acked-by: ``Acker ``h](h Acked-by: }(hj hhhNhNubjX)}(h``Acker ``h]hAcker }(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj ubeh}(h]h ]h"]h$]h&]uh1hhhhMmhj~ ubah}(h]h ]h"]h$]h&]uh1jhjubj)}(hCc: ``cc-ed-person `` If the patch should be backported to stable, then please add a '``Cc: stable@vger.kernel.org``' tag, but do not Cc stable when sending your mail. h](h)}(h"Cc: ``cc-ed-person ``h](hCc: }(hj hhhNhNubjX)}(h``cc-ed-person ``h]hcc-ed-person }(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj ubeh}(h]h ]h"]h$]h&]uh1hhhhMohj ubh)}(hIf the patch should be backported to stable, then please add a '``Cc: stable@vger.kernel.org``' tag, but do not Cc stable when sending your mail.h](hBIf the patch should be backported to stable, then please add a ‘}(hj hhhNhNubjX)}(h``Cc: stable@vger.kernel.org``h]hCc: stable@vger.kernel.org}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj ubh5’ tag, but do not Cc stable when sending your mail.}(hj hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMqhj ubeh}(h]h ]h"]h$]h&]uh1jhjubj)}(hXLink: ``https://link/to/information`` For referring to an email posted to the kernel mailing lists, please use the lore.kernel.org redirector URL:: Link: https://lore.kernel.org/email-message-id@here This URL should be used when referring to relevant mailing list topics, related patch sets, or other notable discussion threads. A convenient way to associate ``Link:`` trailers with the commit message is to use markdown-like bracketed notation, for example:: A similar approach was attempted before as part of a different effort [1], but the initial implementation caused too many regressions [2], so it was backed out and reimplemented. Link: https://lore.kernel.org/some-msgid@here # [1] Link: https://bugzilla.example.org/bug/12345 # [2] You can also use ``Link:`` trailers to indicate the origin of the patch when applying it to your git tree. In that case, please use the dedicated ``patch.msgid.link`` domain instead of ``lore.kernel.org``. This practice makes it possible for automated tooling to identify which link to use to retrieve the original patch submission. For example:: Link: https://patch.msgid.link/patch-source-message-id@here h](h)}(h%Link: ``https://link/to/information``h](hLink: }(hj hhhNhNubjX)}(h``https://link/to/information``h]hhttps://link/to/information}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj ubeh}(h]h ]h"]h$]h&]uh1hhhhMuhj ubh)}(hmFor referring to an email posted to the kernel mailing lists, please use the lore.kernel.org redirector URL::h]hlFor referring to an email posted to the kernel mailing lists, please use the lore.kernel.org redirector URL:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMwhj ubjI)}(h3Link: https://lore.kernel.org/email-message-id@hereh]h3Link: https://lore.kernel.org/email-message-id@here}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMzhj ubh)}(hXThis URL should be used when referring to relevant mailing list topics, related patch sets, or other notable discussion threads. A convenient way to associate ``Link:`` trailers with the commit message is to use markdown-like bracketed notation, for example::h](hThis URL should be used when referring to relevant mailing list topics, related patch sets, or other notable discussion threads. A convenient way to associate }(hj& hhhNhNubjX)}(h ``Link:``h]hLink:}(hj. hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj& ubhZ trailers with the commit message is to use markdown-like bracketed notation, for example:}(hj& hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhM|hj ubjI)}(hXA similar approach was attempted before as part of a different effort [1], but the initial implementation caused too many regressions [2], so it was backed out and reimplemented. Link: https://lore.kernel.org/some-msgid@here # [1] Link: https://bugzilla.example.org/bug/12345 # [2]h]hXA similar approach was attempted before as part of a different effort [1], but the initial implementation caused too many regressions [2], so it was backed out and reimplemented. Link: https://lore.kernel.org/some-msgid@here # [1] Link: https://bugzilla.example.org/bug/12345 # [2]}hjF sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj ubh)}(hXZYou can also use ``Link:`` trailers to indicate the origin of the patch when applying it to your git tree. In that case, please use the dedicated ``patch.msgid.link`` domain instead of ``lore.kernel.org``. This practice makes it possible for automated tooling to identify which link to use to retrieve the original patch submission. For example::h](hYou can also use }(hjT hhhNhNubjX)}(h ``Link:``h]hLink:}(hj\ hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjT ubhx trailers to indicate the origin of the patch when applying it to your git tree. In that case, please use the dedicated }(hjT hhhNhNubjX)}(h``patch.msgid.link``h]hpatch.msgid.link}(hjn hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjT ubh domain instead of }(hjT hhhNhNubjX)}(h``lore.kernel.org``h]hlore.kernel.org}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjT ubh. This practice makes it possible for automated tooling to identify which link to use to retrieve the original patch submission. For example:}(hjT hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMhj ubjI)}(h;Link: https://patch.msgid.link/patch-source-message-id@hereh]h;Link: https://patch.msgid.link/patch-source-message-id@here}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj ubeh}(h]h ]h"]h$]h&]uh1jhjubeh}(h]h ]h"]h$]h&]j@jAuh1jhhhMhjubah}(h]h ]h"]h$]h&]uh1j hhhMhjhhubh)}(hwPlease do not use combined tags, e.g. ``Reported-and-tested-by``, as they just complicate automated extraction of tags.h](h&Please do not use combined tags, e.g. }(hj hhhNhNubjX)}(h``Reported-and-tested-by``h]hReported-and-tested-by}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1jWhj ubh7, as they just complicate automated extraction of tags.}(hj hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMhjhhubeh}(h]ordering-of-commit-tagsah ]h"]ordering of commit tagsah$]h&]uh1hhjIhhhhhM ubh)}(hhh](h)}(hLinks to documentationh]hLinks to documentation}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj hhhhhMubh)}(hX Providing links to documentation in the changelog is a great help to later debugging and analysis. Unfortunately, URLs often break very quickly because companies restructure their websites frequently. Non-'volatile' exceptions include the Intel SDM and the AMD APM.h]hXProviding links to documentation in the changelog is a great help to later debugging and analysis. Unfortunately, URLs often break very quickly because companies restructure their websites frequently. Non-‘volatile’ exceptions include the Intel SDM and the AMD APM.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubh)}(hTherefore, for 'volatile' documents, please create an entry in the kernel bugzilla https://bugzilla.kernel.org and attach a copy of these documents to the bugzilla entry. Finally, provide the URL of the bugzilla entry in the changelog.h](hWTherefore, for ‘volatile’ documents, please create an entry in the kernel bugzilla }(hj hhhNhNubh)}(hhttps://bugzilla.kernel.orgh]hhttps://bugzilla.kernel.org}(hj hhhNhNubah}(h]h ]h"]h$]h&]refurij uh1hhj ubh} and attach a copy of these documents to the bugzilla entry. Finally, provide the URL of the bugzilla entry in the changelog.}(hj hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMhj hhubeh}(h]links-to-documentationah ]h"]links to documentationah$]h&]uh1hhjIhhhhhMubh)}(hhh](h)}(hPatch resend or remindersh]hPatch resend or reminders}(hj+ hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj( hhhhhMubh)}(hSee :ref:`resend_reminders`.h](hSee }(hj9 hhhNhNubh)}(h:ref:`resend_reminders`h]j)}(hjC h]hresend_reminders}(hjE hhhNhNubah}(h]h ](jstdstd-refeh"]h$]h&]uh1jhjA ubah}(h]h ]h"]h$]h&]refdocj refdomainjO reftyperef refexplicitrefwarnjresend_remindersuh1hhhhMhj9 ubh.}(hj9 hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMhj( hhubeh}(h]patch-resend-or-remindersah ]h"]patch resend or remindersah$]h&]uh1hhjIhhhhhMubh)}(hhh](h)}(h Merge windowh]h Merge window}(hjv hhhNhNubah}(h]h ]h"]h$]h&]uh1hhjs hhhhhMubh)}(hPlease do not expect patches to be reviewed or merged by tip maintainers around or during the merge window. The trees are closed to all but urgent fixes during this time. They reopen once the merge window closes and a new -rc1 kernel has been released.h]hPlease do not expect patches to be reviewed or merged by tip maintainers around or during the merge window. The trees are closed to all but urgent fixes during this time. They reopen once the merge window closes and a new -rc1 kernel has been released.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjs hhubh)}(hLarge series should be submitted in mergeable state *at* *least* a week before the merge window opens. Exceptions are made for bug fixes and *sometimes* for small standalone drivers for new hardware or minimally invasive patches for hardware enablement.h](h4Large series should be submitted in mergeable state }(hj hhhNhNubhemphasis)}(h*at*h]hat}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1j hj ubh }(hj hhhNhNubj )}(h*least*h]hleast}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1j hj ubhN a week before the merge window opens. Exceptions are made for bug fixes and }(hj hhhNhNubj )}(h *sometimes*h]h sometimes}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1j hj ubhe for small standalone drivers for new hardware or minimally invasive patches for hardware enablement.}(hj hhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMhjs hhubh)}(hDuring the merge window, the maintainers instead focus on following the upstream changes, fixing merge window fallout, collecting bug fixes, and allowing themselves a breath. Please respect that.h]hDuring the merge window, the maintainers instead focus on following the upstream changes, fixing merge window fallout, collecting bug fixes, and allowing themselves a breath. Please respect that.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjs hhubh)}(hhSo called _urgent_ branches will be merged into mainline during the stabilization phase of each release.h]hhSo called _urgent_ branches will be merged into mainline during the stabilization phase of each release.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjs hhubeh}(h] merge-windowah ]h"] merge windowah$]h&]uh1hhjIhhhhhMubh)}(hhh](h)}(hGith]hGit}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj hhhhhMubh)}(h|The tip maintainers accept git pull requests from maintainers who provide subsystem changes for aggregation in the tip tree.h]h|The tip maintainers accept git pull requests from maintainers who provide subsystem changes for aggregation in the tip tree.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubh)}(hPull requests for new patch submissions are usually not accepted and do not replace proper patch submission to the mailing list. The main reason for this is that the review workflow is email based.h]hPull requests for new patch submissions are usually not accepted and do not replace proper patch submission to the mailing list. The main reason for this is that the review workflow is email based.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubh)}(hIf you submit a larger patch series it is helpful to provide a git branch in a private repository which allows interested people to easily pull the series for testing. The usual way to offer this is a git URL in the cover letter of the patch series.h]hIf you submit a larger patch series it is helpful to provide a git branch in a private repository which allows interested people to easily pull the series for testing. The usual way to offer this is a git URL in the cover letter of the patch series.}(hj) hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubeh}(h]gitah ]h"]gitah$]h&]uh1hhjIhhhhhMubh)}(hhh](h)}(hTestingh]hTesting}(hjB hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj? hhhhhMubh)}(hCode should be tested before submitting to the tip maintainers. Anything other than minor changes should be built, booted and tested with comprehensive (and heavyweight) kernel debugging options enabled.h]hCode should be tested before submitting to the tip maintainers. Anything other than minor changes should be built, booted and tested with comprehensive (and heavyweight) kernel debugging options enabled.}(hjP hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj? hhubh)}(hThese debugging options can be found in kernel/configs/x86_debug.config and can be added to an existing kernel config by running:h]hThese debugging options can be found in kernel/configs/x86_debug.config and can be added to an existing kernel config by running:}(hj^ hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj? hhubj )}(hmake x86_debug.config h]h)}(hmake x86_debug.configh]hmake x86_debug.config}(hjp hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjl ubah}(h]h ]h"]h$]h&]uh1j hhhMhj? hhubh)}(h_Some of these options are x86-specific and can be left out when testing on other architectures.h]h_Some of these options are x86-specific and can be left out when testing on other architectures.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj? hhubhtarget)}(h .. _maintainer-tip-coding-style:h]h}(h]h ]h"]h$]h&]refidmaintainer-tip-coding-styleuh1j hMhj? hhhhubeh}(h]testingah ]h"]testingah$]h&]uh1hhjIhhhhhMubeh}(h]patch-submission-notesah ]h"]patch submission notesah$]h&]uh1hhhhhhhhKeubh)}(hhh](h)}(hCoding style notesh]hCoding style notes}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h Comment styleh]h Comment style}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj hhhhhMubh)}(h5Sentences in comments start with an uppercase letter.h]h5Sentences in comments start with an uppercase letter.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubh)}(hSingle line comments::h]hSingle line comments:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubjI)}(h#/* This is a single line comment */h]h#/* This is a single line comment */}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj hhubh)}(hMulti-line comments::h]hMulti-line comments:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubjI)}(h/* * This is a properly formatted * multi-line comment. * * Larger multi-line comments should be split into paragraphs. */h]h/* * This is a properly formatted * multi-line comment. * * Larger multi-line comments should be split into paragraphs. */}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj hhubh)}(hNo tail comments (see below):h]hNo tail comments (see below):}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj hhubj )}(hXPlease refrain from using tail comments. Tail comments disturb the reading flow in almost all contexts, but especially in code:: if (somecondition_is_true) /* Don't put a comment here */ dostuff(); /* Neither here */ seed = MAGIC_CONSTANT; /* Nor here */ Use freestanding comments instead:: /* This condition is not obvious without a comment */ if (somecondition_is_true) { /* This really needs to be documented */ dostuff(); } /* This magic initialization needs a comment. Maybe not? */ seed = MAGIC_CONSTANT; Use C++ style, tail comments when documenting structs in headers to achieve a more compact layout and better readability:: // eax u32 x2apic_shift : 5, // Number of bits to shift APIC ID right // for the topology ID at the next level : 27; // Reserved // ebx u32 num_processors : 16, // Number of processors at current level : 16; // Reserved versus:: /* eax */ /* * Number of bits to shift APIC ID right for the topology ID * at the next level */ u32 x2apic_shift : 5, /* Reserved */ : 27; /* ebx */ /* Number of processors at current level */ u32 num_processors : 16, /* Reserved */ : 16; h](h)}(hPlease refrain from using tail comments. Tail comments disturb the reading flow in almost all contexts, but especially in code::h]hPlease refrain from using tail comments. Tail comments disturb the reading flow in almost all contexts, but especially in code:}(hj* hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj& ubjI)}(hif (somecondition_is_true) /* Don't put a comment here */ dostuff(); /* Neither here */ seed = MAGIC_CONSTANT; /* Nor here */h]hif (somecondition_is_true) /* Don't put a comment here */ dostuff(); /* Neither here */ seed = MAGIC_CONSTANT; /* Nor here */}hj8 sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj& ubh)}(h#Use freestanding comments instead::h]h"Use freestanding comments instead:}(hjF hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj& ubjI)}(h/* This condition is not obvious without a comment */ if (somecondition_is_true) { /* This really needs to be documented */ dostuff(); } /* This magic initialization needs a comment. Maybe not? */ seed = MAGIC_CONSTANT;h]h/* This condition is not obvious without a comment */ if (somecondition_is_true) { /* This really needs to be documented */ dostuff(); } /* This magic initialization needs a comment. Maybe not? */ seed = MAGIC_CONSTANT;}hjT sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj& ubh)}(hzUse C++ style, tail comments when documenting structs in headers to achieve a more compact layout and better readability::h]hyUse C++ style, tail comments when documenting structs in headers to achieve a more compact layout and better readability:}(hjb hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj& ubjI)}(hX6// eax u32 x2apic_shift : 5, // Number of bits to shift APIC ID right // for the topology ID at the next level : 27; // Reserved // ebx u32 num_processors : 16, // Number of processors at current level : 16; // Reservedh]hX6// eax u32 x2apic_shift : 5, // Number of bits to shift APIC ID right // for the topology ID at the next level : 27; // Reserved // ebx u32 num_processors : 16, // Number of processors at current level : 16; // Reserved}hjp sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM hj& ubh)}(hversus::h]hversus:}(hj~ hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj& ubjI)}(hXj/* eax */ /* * Number of bits to shift APIC ID right for the topology ID * at the next level */ u32 x2apic_shift : 5, /* Reserved */ : 27; /* ebx */ /* Number of processors at current level */ u32 num_processors : 16, /* Reserved */ : 16;h]hXj/* eax */ /* * Number of bits to shift APIC ID right for the topology ID * at the next level */ u32 x2apic_shift : 5, /* Reserved */ : 27; /* ebx */ /* Number of processors at current level */ u32 num_processors : 16, /* Reserved */ : 16;}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhj& ubeh}(h]h ]h"]h$]h&]uh1j hhhMhj hhubh)}(hComment the important things:h]hComment the important things:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM"hj hhubj )}(hX+Comments should be added where the operation is not obvious. Documenting the obvious is just a distraction:: /* Decrement refcount and check for zero */ if (refcount_dec_and_test(&p->refcnt)) { do; lots; of; magic; things; } Instead, comments should explain the non-obvious details and document constraints:: if (refcount_dec_and_test(&p->refcnt)) { /* * Really good explanation why the magic things below * need to be done, ordering and locking constraints, * etc.. */ do; lots; of; magic; /* Needs to be the last operation because ... */ things; } h](h)}(hlComments should be added where the operation is not obvious. Documenting the obvious is just a distraction::h]hkComments should be added where the operation is not obvious. Documenting the obvious is just a distraction:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM$hj ubjI)}(h/* Decrement refcount and check for zero */ if (refcount_dec_and_test(&p->refcnt)) { do; lots; of; magic; things; }h]h/* Decrement refcount and check for zero */ if (refcount_dec_and_test(&p->refcnt)) { do; lots; of; magic; things; }}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM'hj ubh)}(hSInstead, comments should explain the non-obvious details and document constraints::h]hRInstead, comments should explain the non-obvious details and document constraints:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM0hj ubjI)}(hXLif (refcount_dec_and_test(&p->refcnt)) { /* * Really good explanation why the magic things below * need to be done, ordering and locking constraints, * etc.. */ do; lots; of; magic; /* Needs to be the last operation because ... */ things; }h]hXLif (refcount_dec_and_test(&p->refcnt)) { /* * Really good explanation why the magic things below * need to be done, ordering and locking constraints, * etc.. */ do; lots; of; magic; /* Needs to be the last operation because ... */ things; }}hj sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM3hj ubeh}(h]h ]h"]h$]h&]uh1j hhhM$hj hhubh)}(h Function documentation comments:h]h Function documentation comments:}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMAhj hhubj )}(hXCTo document functions and their arguments please use kernel-doc format and not free form comments:: /** * magic_function - Do lots of magic stuff * @magic: Pointer to the magic data to operate on * @offset: Offset in the data array of @magic * * Deep explanation of mysterious things done with @magic along * with documentation of the return values. * * Note, that the argument descriptors above are arranged * in a tabular fashion. */ This applies especially to globally visible functions and inline functions in public header files. It might be overkill to use kernel-doc format for every (static) function which needs a tiny explanation. The usage of descriptive function names often replaces these tiny comments. Apply common sense as always. h](h)}(hcTo document functions and their arguments please use kernel-doc format and not free form comments::h]hbTo document functions and their arguments please use kernel-doc format and not free form comments:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMChj ubjI)}(hXb/** * magic_function - Do lots of magic stuff * @magic: Pointer to the magic data to operate on * @offset: Offset in the data array of @magic * * Deep explanation of mysterious things done with @magic along * with documentation of the return values. * * Note, that the argument descriptors above are arranged * in a tabular fashion. */h]hXb/** * magic_function - Do lots of magic stuff * @magic: Pointer to the magic data to operate on * @offset: Offset in the data array of @magic * * Deep explanation of mysterious things done with @magic along * with documentation of the return values. * * Note, that the argument descriptors above are arranged * in a tabular fashion. */}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMFhj ubh)}(hX6This applies especially to globally visible functions and inline functions in public header files. It might be overkill to use kernel-doc format for every (static) function which needs a tiny explanation. The usage of descriptive function names often replaces these tiny comments. Apply common sense as always.h]hX6This applies especially to globally visible functions and inline functions in public header files. It might be overkill to use kernel-doc format for every (static) function which needs a tiny explanation. The usage of descriptive function names often replaces these tiny comments. Apply common sense as always.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMRhj ubeh}(h]h ]h"]h$]h&]uh1j hhhMChj hhubeh}(h] comment-styleah ]h"] comment styleah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h Documenting locking requirementsh]h Documenting locking requirements}(hj=hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj:hhhhhMZubj )}(hXDocumenting locking requirements is a good thing, but comments are not necessarily the best choice. Instead of writing:: /* Caller must hold foo->lock */ void func(struct foo *foo) { ... } Please use:: void func(struct foo *foo) { lockdep_assert_held(&foo->lock); ... } In PROVE_LOCKING kernels, lockdep_assert_held() emits a warning if the caller doesn't hold the lock. Comments can't do that. h](h)}(hxDocumenting locking requirements is a good thing, but comments are not necessarily the best choice. Instead of writing::h]hwDocumenting locking requirements is a good thing, but comments are not necessarily the best choice. Instead of writing:}(hjOhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM[hjKubjI)}(hK/* Caller must hold foo->lock */ void func(struct foo *foo) { ... }h]hK/* Caller must hold foo->lock */ void func(struct foo *foo) { ... }}hj]sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM^hjKubh)}(h Please use::h]h Please use:}(hjkhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMdhjKubjI)}(hSvoid func(struct foo *foo) { lockdep_assert_held(&foo->lock); ... }h]hSvoid func(struct foo *foo) { lockdep_assert_held(&foo->lock); ... }}hjysbah}(h]h ]h"]h$]h&]hhuh1jHhhhMfhjKubh)}(h}In PROVE_LOCKING kernels, lockdep_assert_held() emits a warning if the caller doesn't hold the lock. Comments can't do that.h]hIn PROVE_LOCKING kernels, lockdep_assert_held() emits a warning if the caller doesn’t hold the lock. Comments can’t do that.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMlhjKubeh}(h]h ]h"]h$]h&]uh1j hhhM[hj:hhubeh}(h] documenting-locking-requirementsah ]h"] documenting locking requirementsah$]h&]uh1hhj hhhhhMZubh)}(hhh](h)}(h Bracket rulesh]h Bracket rules}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhMpubh)}(hqBrackets should be omitted only if the statement which follows 'if', 'for', 'while' etc. is truly a single line::h]h|Brackets should be omitted only if the statement which follows ‘if’, ‘for’, ‘while’ etc. is truly a single line:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMrhjhhubjI)}(h if (foo) do_something();h]h if (foo) do_something();}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMuhjhhubh)}(hgThe following is not considered to be a single line statement even though C does not require brackets::h]hfThe following is not considered to be a single line statement even though C does not require brackets:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMxhjhhubjI)}(hSfor (i = 0; i < end; i++) if (foo[i]) do_something(foo[i]);h]hSfor (i = 0; i < end; i++) if (foo[i]) do_something(foo[i]);}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhM{hjhhubh)}(hAAdding brackets around the outer loop enhances the reading flow::h]h@Adding brackets around the outer loop enhances the reading flow:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hWfor (i = 0; i < end; i++) { if (foo[i]) do_something(foo[i]); }h]hWfor (i = 0; i < end; i++) { if (foo[i]) do_something(foo[i]); }}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubeh}(h] bracket-rulesah ]h"] bracket rulesah$]h&]uh1hhj hhhhhMpubh)}(hhh](h)}(hVariable declarationsh]hVariable declarations}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhMubh)}(hjThe preferred ordering of variable declarations at the beginning of a function is reverse fir tree order::h]hiThe preferred ordering of variable declarations at the beginning of a function is reverse fir tree order:}(hj!hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(h]struct long_struct_name *descriptive_name; unsigned long foo, bar; unsigned int tmp; int ret;h]h]struct long_struct_name *descriptive_name; unsigned long foo, bar; unsigned int tmp; int ret;}hj/sbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(h8The above is faster to parse than the reverse ordering::h]h7The above is faster to parse than the reverse ordering:}(hj=hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(h]int ret; unsigned int tmp; unsigned long foo, bar; struct long_struct_name *descriptive_name;h]h]int ret; unsigned int tmp; unsigned long foo, bar; struct long_struct_name *descriptive_name;}hjKsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(h'And even more so than random ordering::h]h&And even more so than random ordering:}(hjYhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(h]unsigned long foo, bar; int ret; struct long_struct_name *descriptive_name; unsigned int tmp;h]h]unsigned long foo, bar; int ret; struct long_struct_name *descriptive_name; unsigned int tmp;}hjgsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(hwAlso please try to aggregate variables of the same type into a single line. There is no point in wasting screen space::h]hvAlso please try to aggregate variables of the same type into a single line. There is no point in wasting screen space:}(hjuhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hCunsigned long a; unsigned long b; unsigned long c; unsigned long d;h]hCunsigned long a; unsigned long b; unsigned long c; unsigned long d;}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(hIt's really sufficient to do::h]hIt’s really sufficient to do:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hunsigned long a, b, c, d;h]hunsigned long a, b, c, d;}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(hKPlease also refrain from introducing line splits in variable declarations::h]hJPlease also refrain from introducing line splits in variable declarations:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hstruct long_struct_name *descriptive_name = container_of(bar, struct long_struct_name, member); struct foobar foo;h]hstruct long_struct_name *descriptive_name = container_of(bar, struct long_struct_name, member); struct foobar foo;}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubh)}(hVIt's way better to move the initialization to a separate line after the declarations::h]hWIt’s way better to move the initialization to a separate line after the declarations:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hstruct long_struct_name *descriptive_name; struct foobar foo; descriptive_name = container_of(bar, struct long_struct_name, member);h]hstruct long_struct_name *descriptive_name; struct foobar foo; descriptive_name = container_of(bar, struct long_struct_name, member);}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjhhubeh}(h]variable-declarationsah ]h"]variable declarationsah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(hVariable typesh]hVariable types}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhMubh)}(hXPlease use the proper u8, u16, u32, u64 types for variables which are meant to describe hardware or are used as arguments for functions which access hardware. These types are clearly defining the bit width and avoid truncation, expansion and 32/64-bit confusion.h]hXPlease use the proper u8, u16, u32, u64 types for variables which are meant to describe hardware or are used as arguments for functions which access hardware. These types are clearly defining the bit width and avoid truncation, expansion and 32/64-bit confusion.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubh)}(hX7u64 is also recommended in code which would become ambiguous for 32-bit kernels when 'unsigned long' would be used instead. While in such situations 'unsigned long long' could be used as well, u64 is shorter and also clearly shows that the operation is required to be 64 bits wide independent of the target CPU.h]hX?u64 is also recommended in code which would become ambiguous for 32-bit kernels when ‘unsigned long’ would be used instead. While in such situations ‘unsigned long long’ could be used as well, u64 is shorter and also clearly shows that the operation is required to be 64 bits wide independent of the target CPU.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubh)}(h0Please use 'unsigned int' instead of 'unsigned'.h]h8Please use ‘unsigned int’ instead of ‘unsigned’.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubeh}(h]variable-typesah ]h"]variable typesah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h Constantsh]h Constants}(hj3hhhNhNubah}(h]h ]h"]h$]h&]uh1hhj0hhhhhMubh)}(hPlease do not use literal (hexa)decimal numbers in code or initializers. Either use proper defines which have descriptive names or consider using an enum.h]hPlease do not use literal (hexa)decimal numbers in code or initializers. Either use proper defines which have descriptive names or consider using an enum.}(hjAhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhj0hhubeh}(h] constantsah ]h"] constantsah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h$Struct declarations and initializersh]h$Struct declarations and initializers}(hjZhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjWhhhhhMubh)}(hOStruct declarations should align the struct member names in a tabular fashion::h]hNStruct declarations should align the struct member names in a tabular fashion:}(hjhhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjWhhubjI)}(h|struct bar_order { unsigned int guest_id; int ordered_item; struct menu *menu; };h]h|struct bar_order { unsigned int guest_id; int ordered_item; struct menu *menu; };}hjvsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjWhhubh)}(hPlease avoid documenting struct members within the declaration, because this often results in strangely formatted comments and the struct members become obfuscated::h]hPlease avoid documenting struct members within the declaration, because this often results in strangely formatted comments and the struct members become obfuscated:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjWhhubjI)}(hstruct bar_order { unsigned int guest_id; /* Unique guest id */ int ordered_item; /* Pointer to a menu instance which contains all the drinks */ struct menu *menu; };h]hstruct bar_order { unsigned int guest_id; /* Unique guest id */ int ordered_item; /* Pointer to a menu instance which contains all the drinks */ struct menu *menu; };}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjWhhubh)}(hInstead, please consider using the kernel-doc format in a comment preceding the struct declaration, which is easier to read and has the added advantage of including the information in the kernel documentation, for example, as follows::h]hInstead, please consider using the kernel-doc format in a comment preceding the struct declaration, which is easier to read and has the added advantage of including the information in the kernel documentation, for example, as follows:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjWhhubjI)}(hX/** * struct bar_order - Description of a bar order * @guest_id: Unique guest id * @ordered_item: The item number from the menu * @menu: Pointer to the menu from which the item * was ordered * * Supplementary information for using the struct. * * Note, that the struct member descriptors above are arranged * in a tabular fashion. */ struct bar_order { unsigned int guest_id; int ordered_item; struct menu *menu; };h]hX/** * struct bar_order - Description of a bar order * @guest_id: Unique guest id * @ordered_item: The item number from the menu * @menu: Pointer to the menu from which the item * was ordered * * Supplementary information for using the struct. * * Note, that the struct member descriptors above are arranged * in a tabular fashion. */ struct bar_order { unsigned int guest_id; int ordered_item; struct menu *menu; };}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjWhhubh)}(hfStatic struct initializers must use C99 initializers and should also be aligned in a tabular fashion::h]heStatic struct initializers must use C99 initializers and should also be aligned in a tabular fashion:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjWhhubjI)}(hstatic struct foo statfoo = { .a = 0, .plain_integer = CONSTANT_DEFINE_OR_ENUM, .bar = &statbar, };h]hstatic struct foo statfoo = { .a = 0, .plain_integer = CONSTANT_DEFINE_OR_ENUM, .bar = &statbar, };}hjsbah}(h]h ]h"]h$]h&]hhuh1jHhhhMhjWhhubh)}(hNote that while C99 syntax allows the omission of the final comma, we recommend the use of a comma on the last line because it makes reordering and addition of new lines easier, and makes such future patches slightly easier to read as well.h]hNote that while C99 syntax allows the omission of the final comma, we recommend the use of a comma on the last line because it makes reordering and addition of new lines easier, and makes such future patches slightly easier to read as well.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM hjWhhubeh}(h]$struct-declarations-and-initializersah ]h"]$struct declarations and initializersah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h Line breaksh]h Line breaks}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhMubh)}(hRestricting line length to 80 characters makes deeply indented code hard to read. Consider breaking out code into helper functions to avoid excessive line breaking.h]hRestricting line length to 80 characters makes deeply indented code hard to read. Consider breaking out code into helper functions to avoid excessive line breaking.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubh)}(hThe 80 character rule is not a strict rule, so please use common sense when breaking lines. Especially format strings should never be broken up.h]hThe 80 character rule is not a strict rule, so please use common sense when breaking lines. Especially format strings should never be broken up.}(hj hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubh)}(hWhen splitting function declarations or function calls, then please align the first argument in the second line with the first argument in the first line::h]hWhen splitting function declarations or function calls, then please align the first argument in the second line with the first argument in the first line:}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMhjhhubjI)}(hX static int long_function_name(struct foobar *barfoo, unsigned int id, unsigned int offset) { if (!id) { ret = longer_function_name(barfoo, DEFAULT_BARFOO_ID, offset); ...h]hX static int long_function_name(struct foobar *barfoo, unsigned int id, unsigned int offset) { if (!id) { ret = longer_function_name(barfoo, DEFAULT_BARFOO_ID, offset); ...}hj)sbah}(h]h ]h"]h$]h&]hhuh1jHhhhM hjhhubeh}(h] line-breaksah ]h"] line breaksah$]h&]uh1hhj hhhhhMubh)}(hhh](h)}(h Namespacesh]h Namespaces}(hjBhhhNhNubah}(h]h ]h"]h$]h&]uh1hhj?hhhhhM*ubh)}(hX/Function/variable namespaces improve readability and allow easy grepping. These namespaces are string prefixes for globally visible function and variable names, including inlines. These prefixes should combine the subsystem and the component name such as 'x86_comp\_', 'sched\_', 'irq\_', and 'mutex\_'.h]hX?Function/variable namespaces improve readability and allow easy grepping. These namespaces are string prefixes for globally visible function and variable names, including inlines. These prefixes should combine the subsystem and the component name such as ‘x86_comp_’, ‘sched_’, ‘irq_’, and ‘mutex_’.}(hjPhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM,hj?hhubh)}(hThis also includes static file scope functions that are immediately put into globally visible driver templates - it's useful for those symbols to carry a good prefix as well, for backtrace readability.h]hThis also includes static file scope functions that are immediately put into globally visible driver templates - it’s useful for those symbols to carry a good prefix as well, for backtrace readability.}(hj^hhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM2hj?hhubh)}(hNamespace prefixes may be omitted for local static functions and variables. Truly local functions, only called by other local functions, can have shorter descriptive names - our primary concern is greppability and backtrace readability.h]hNamespace prefixes may be omitted for local static functions and variables. Truly local functions, only called by other local functions, can have shorter descriptive names - our primary concern is greppability and backtrace readability.}(hjlhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM6hj?hhubh)}(hX Please note that 'xxx_vendor\_' and 'vendor_xxx_` prefixes are not helpful for static functions in vendor-specific files. After all, it is already clear that the code is vendor-specific. In addition, vendor names should only be for truly vendor-specific functionality.h]hXPlease note that ‘xxx_vendor_’ and ‘vendor_xxx_` prefixes are not helpful for static functions in vendor-specific files. After all, it is already clear that the code is vendor-specific. In addition, vendor names should only be for truly vendor-specific functionality.}(hjzhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM;hj?hhubh)}(hEAs always apply common sense and aim for consistency and readability.h]hEAs always apply common sense and aim for consistency and readability.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhM@hj?hhubeh}(h] namespacesah ]h"] namespacesah$]h&]uh1hhj hhhhhM*ubeh}(h](coding-style-notesj eh ]h"](coding style notesmaintainer-tip-coding-styleeh$]h&]uh1hhhhhhhhMexpect_referenced_by_name}jj sexpect_referenced_by_id}j j subh)}(hhh](h)}(hCommit notificationsh]hCommit notifications}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhjhhhhhMDubh)}(hXThe tip tree is monitored by a bot for new commits. The bot sends an email for each new commit to a dedicated mailing list (``linux-tip-commits@vger.kernel.org``) and Cc's all people who are mentioned in one of the commit tags. It uses the email message ID from the Link tag at the end of the tag list to set the In-Reply-To email header so the message is properly threaded with the patch submission email.h](h|The tip tree is monitored by a bot for new commits. The bot sends an email for each new commit to a dedicated mailing list (}(hjhhhNhNubjX)}(h%``linux-tip-commits@vger.kernel.org``h]h!linux-tip-commits@vger.kernel.org}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1jWhjubh) and Cc’s all people who are mentioned in one of the commit tags. It uses the email message ID from the Link tag at the end of the tag list to set the In-Reply-To email header so the message is properly threaded with the patch submission email.}(hjhhhNhNubeh}(h]h ]h"]h$]h&]uh1hhhhMFhjhhubh)}(hThe tip maintainers and submaintainers try to reply to the submitter when merging a patch, but they sometimes forget or it does not fit the workflow of the moment. While the bot message is purely mechanical, it also implies a 'Thank you! Applied.'.h]hThe tip maintainers and submaintainers try to reply to the submitter when merging a patch, but they sometimes forget or it does not fit the workflow of the moment. While the bot message is purely mechanical, it also implies a ‘Thank you! Applied.’.}(hjhhhNhNubah}(h]h ]h"]h$]h&]uh1hhhhMMhjhhubeh}(h]commit-notificationsah ]h"]commit notificationsah$]h&]uh1hhhhhhhhMDubeh}(h]the-tip-tree-handbookah ]h"]the tip tree handbookah$]h&]uh1hhhhhhhhKubeh}(h]h ]h"]h$]h&]sourcehuh1hcurrent_sourceN current_lineNsettingsdocutils.frontendValues)}(hN generatorN datestampN source_linkN source_urlN toc_backlinksentryfootnote_backlinksK sectnum_xformKstrip_commentsNstrip_elements_with_classesN strip_classesN report_levelK halt_levelKexit_status_levelKdebugNwarning_streamN tracebackinput_encoding utf-8-siginput_encoding_error_handlerstrictoutput_encodingutf-8output_encoding_error_handlerjerror_encodingutf-8error_encoding_error_handlerbackslashreplace language_codeenrecord_dependenciesNconfigN id_prefixhauto_id_prefixid dump_settingsNdump_internalsNdump_transformsNdump_pseudo_xmlNexpose_internalsNstrict_visitorN_disable_configN_sourceh _destinationN _config_files]7/var/lib/git/docbuild/linux/Documentation/docutils.confafile_insertion_enabled raw_enabledKline_length_limitM'pep_referencesN pep_base_urlhttps://peps.python.org/pep_file_url_templatepep-%04drfc_referencesN rfc_base_url&https://datatracker.ietf.org/doc/html/ tab_widthKtrim_footnote_reference_spacesyntax_highlightlong smart_quotessmartquotes_locales]character_level_inline_markupdoctitle_xform docinfo_xformKsectsubtitle_xform image_loadinglinkembed_stylesheetcloak_email_addressessection_self_linkenvNubreporterNindirect_targets]substitution_defs}substitution_names}refnames}refids}j ]j asnameids}(jjjFjCj j jjjjj'j$jxjujjj j j% j" jp jm j j j< j9 j j jj jjj7j4jjj j jjj-j*jTjQjjj<j9jjjju nametypes}(jjFj jjj'jxjj j% jp j j< j jjj7jj jj-jTjj<jjuh}(jhjChj jIjjZjjj$jjuj*jj{j jj" j jm j( j js j9 j j j? j j jj j4j jj:j jjjj*jjQj0jjWj9jjj?jju footnote_refs} citation_refs} autofootnotes]autofootnote_refs]symbol_footnotes]symbol_footnote_refs] footnotes] citations]autofootnote_startKsymbol_footnote_startK id_counter collectionsCounter}Rparse_messages]transform_messages]hsystem_message)}(hhh]h)}(hhh]hAHyperlink target "maintainer-tip-coding-style" is not referenced.}hjsbah}(h]h ]h"]h$]h&]uh1hhjubah}(h]h ]h"]h$]h&]levelKtypeINFOsourcehlineMuh1juba transformerN include_log] decorationNhhub.