From 0f1d4813a4a65296e1131f320a60741732bc068f Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Sat, 8 Jan 2005 03:59:53 -0800 Subject: [PATCH] SDLA firmware upgrade should require CAP_SYS_RAWIO (not just CAP_NET_ADMIN) There were a few variants on the list trying to work out what the valid ranges to verify for write are but they sort of missed the point, if you can load new firmware you can have fun anyway. --- drivers/net/wan/sdla.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c index f0ed00ef06fee1..71f95462d58571 100644 --- a/drivers/net/wan/sdla.c +++ b/drivers/net/wan/sdla.c @@ -1306,6 +1306,8 @@ NOTE: This is rather a useless action right now, as the case SDLA_WRITEMEM: case SDLA_READMEM: + if(!capable(CAP_SYS_RAWIO)) + return -EPERM; return(sdla_xfer(dev, ifr->ifr_data, cmd == SDLA_READMEM)); case SDLA_START: -- cgit 1.2.3-korg