diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2018-07-31 17:12:52 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-08-09 12:20:33 +0200 |
| commit | 1aa222b3b245f2e656b90271b9994232f9b786a2 (patch) | |
| tree | f8b5c5066dabd384b3fe19100b71a87afe6e2b04 | |
| parent | 95478b56ac4fddc84ade05c4cf95a524af58d16c (diff) | |
| download | linux-1aa222b3b245f2e656b90271b9994232f9b786a2.tar.gz | |
net: dsa: Do not suspend/resume closed slave_dev
[ Upstream commit a94c689e6c9e72e722f28339e12dff191ee5a265 ]
If a DSA slave network device was previously disabled, there is no need
to suspend or resume it.
Fixes: 2446254915a7 ("net: dsa: allow switch drivers to implement suspend/resume hooks")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/dsa/slave.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index ab03e00ffe8f0e..95f63b79f03eb9 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -503,6 +503,9 @@ int dsa_slave_suspend(struct net_device *slave_dev) { struct dsa_slave_priv *p = netdev_priv(slave_dev); + if (!netif_running(slave_dev)) + return 0; + netif_device_detach(slave_dev); if (p->phy) { @@ -520,6 +523,9 @@ int dsa_slave_resume(struct net_device *slave_dev) { struct dsa_slave_priv *p = netdev_priv(slave_dev); + if (!netif_running(slave_dev)) + return 0; + netif_device_attach(slave_dev); if (p->phy) { |